Skip to content

Commit 1c75d5d

Browse files
committed
Remove unnecessary timeout running added during wip to ensure catching all updates
1 parent 102324b commit 1c75d5d

6 files changed

Lines changed: 0 additions & 62 deletions

src/testRunner/unittests/tsserver/typeAquisition.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ describe("unittests:: tsserver:: typeAquisition:: changes", () => {
8686
host.runPendingInstalls();
8787
host.runQueuedTimeoutCallbacks(); // First project upate after typings are installed
8888
host.runQueuedTimeoutCallbacks(); // Update scheduled after the typings from unresolved imports are discovered again
89-
host.runQueuedTimeoutCallbacks();
9089
disableTypeAcquisition();
9190
host.runQueuedTimeoutCallbacks();
9291
verifyEnabledTypeAcquisition();
@@ -113,7 +112,6 @@ describe("unittests:: tsserver:: typeAquisition:: changes", () => {
113112
disableTypeAcquisition();
114113
host.runQueuedTimeoutCallbacks(); // Update project
115114
host.runPendingInstalls();
116-
host.runQueuedTimeoutCallbacks();
117115
verifyEnabledTypeAcquisition();
118116
baselineTsserverLogs("typeAquisition", "receives update of typings after project changes", session);
119117
});
@@ -126,8 +124,6 @@ describe("unittests:: tsserver:: typeAquisition:: changes", () => {
126124
verifyEnabledTypeAcquisition();
127125
host.runPendingInstalls();
128126
host.runQueuedTimeoutCallbacks();
129-
host.runQueuedTimeoutCallbacks();
130-
host.runQueuedTimeoutCallbacks();
131127
baselineTsserverLogs("typeAquisition", "change after enabling typeAquisition", session);
132128
});
133129

@@ -173,8 +169,6 @@ describe("unittests:: tsserver:: typeAquisition:: changes", () => {
173169
function verifyEnabledTypeAcquisition() {
174170
typeAcquisition(/*enable*/ true);
175171
host.runQueuedTimeoutCallbacks();
176-
host.runQueuedTimeoutCallbacks();
177-
host.runQueuedTimeoutCallbacks();
178172
}
179173

180174
function disableTypeAcquisition() {

tests/baselines/reference/tsserver/typeAquisition/change-after-enabling-typeAquisition.js

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -643,26 +643,10 @@ FsWatchesRecursive::
643643
Timeout callback:: count: 0
644644
4: /users/user/projects/project1/jsconfig.jsonFailedLookupInvalidation *deleted*
645645

646-
Before running Timeout callback:: count: 0
647-
648-
After running Timeout callback:: count: 0
649-
650-
Before running Timeout callback:: count: 0
651-
652-
After running Timeout callback:: count: 0
653-
654646
Before running PendingInstalls callback:: count: 0
655647

656648
After running PendingInstalls callback:: count: 0
657649

658650
Before running Timeout callback:: count: 0
659651

660652
After running Timeout callback:: count: 0
661-
662-
Before running Timeout callback:: count: 0
663-
664-
After running Timeout callback:: count: 0
665-
666-
Before running Timeout callback:: count: 0
667-
668-
After running Timeout callback:: count: 0

tests/baselines/reference/tsserver/typeAquisition/changes-to-typeAquisition-when-typing-installer-installs-typing.js

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -724,10 +724,6 @@ Info seq [hh:mm:ss:mss] event:
724724
}
725725
After running Timeout callback:: count: 0
726726
727-
Before running Timeout callback:: count: 0
728-
729-
After running Timeout callback:: count: 0
730-
731727
Info seq [hh:mm:ss:mss] FileWatcher:: Triggered with /users/user/projects/project1/jsconfig.json 1:: WatchInfo: /users/user/projects/project1/jsconfig.json 2000 undefined Project: /users/user/projects/project1/jsconfig.json WatchType: Config file
732728
Info seq [hh:mm:ss:mss] Scheduled: /users/user/projects/project1/jsconfig.json
733729
Info seq [hh:mm:ss:mss] Scheduled: *ensureProjectForOpenFiles*
@@ -1270,11 +1266,3 @@ FsWatchesRecursive::
12701266
{}
12711267
/users/user/projects/typings/node_modules: *new*
12721268
{}
1273-
1274-
Before running Timeout callback:: count: 0
1275-
1276-
After running Timeout callback:: count: 0
1277-
1278-
Before running Timeout callback:: count: 0
1279-
1280-
After running Timeout callback:: count: 0

tests/baselines/reference/tsserver/typeAquisition/changes-to-typeAquisition-with-already-aquired-typing.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -980,11 +980,3 @@ FsWatchesRecursive::
980980
{}
981981
/users/user/projects/typings/node_modules: *new*
982982
{}
983-
984-
Before running Timeout callback:: count: 0
985-
986-
After running Timeout callback:: count: 0
987-
988-
Before running Timeout callback:: count: 0
989-
990-
After running Timeout callback:: count: 0

tests/baselines/reference/tsserver/typeAquisition/midway-changes-to-typeAquisition-when-typing-installer-installs-typing.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1029,11 +1029,3 @@ FsWatchesRecursive::
10291029
{}
10301030
/users/user/projects/typings/node_modules: *new*
10311031
{}
1032-
1033-
Before running Timeout callback:: count: 0
1034-
1035-
After running Timeout callback:: count: 0
1036-
1037-
Before running Timeout callback:: count: 0
1038-
1039-
After running Timeout callback:: count: 0

tests/baselines/reference/tsserver/typeAquisition/receives-update-of-typings-after-project-changes.js

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -705,10 +705,6 @@ Info seq [hh:mm:ss:mss] event:
705705
}
706706
After running PendingInstalls callback:: count: 0
707707
708-
Before running Timeout callback:: count: 0
709-
710-
After running Timeout callback:: count: 0
711-
712708
Info seq [hh:mm:ss:mss] FileWatcher:: Triggered with /users/user/projects/project1/jsconfig.json 1:: WatchInfo: /users/user/projects/project1/jsconfig.json 2000 undefined Project: /users/user/projects/project1/jsconfig.json WatchType: Config file
713709
Info seq [hh:mm:ss:mss] Scheduled: /users/user/projects/project1/jsconfig.json
714710
Info seq [hh:mm:ss:mss] Scheduled: *ensureProjectForOpenFiles*
@@ -1025,11 +1021,3 @@ FsWatchesRecursive::
10251021
{}
10261022
/users/user/projects/typings/node_modules: *new*
10271023
{}
1028-
1029-
Before running Timeout callback:: count: 0
1030-
1031-
After running Timeout callback:: count: 0
1032-
1033-
Before running Timeout callback:: count: 0
1034-
1035-
After running Timeout callback:: count: 0

0 commit comments

Comments
 (0)