[SM6.10][HLK][Bugfix] Remove using std from common header#8358
Merged
V-FEXrt merged 2 commits intomicrosoft:mainfrom Apr 9, 2026
Merged
[SM6.10][HLK][Bugfix] Remove using std from common header#8358V-FEXrt merged 2 commits intomicrosoft:mainfrom
V-FEXrt merged 2 commits intomicrosoft:mainfrom
Conversation
Contributor
You can test this locally with the following command:git-clang-format --diff aba4445f744167b1bced5973a57b64047a1075b8 48a54ee9e8b23bf03eb697b7b9d8ad1840a6ef77 -- include/dxc/Test/HlslTestUtils.h tools/clang/unittests/HLSLExec/ExecutionTest.cppView the diff from clang-format here.diff --git a/include/dxc/Test/HlslTestUtils.h b/include/dxc/Test/HlslTestUtils.h
index 324dfa66..a6a979cd 100644
--- a/include/dxc/Test/HlslTestUtils.h
+++ b/include/dxc/Test/HlslTestUtils.h
@@ -47,8 +47,8 @@
#include "dxc/Test/TestConfig.h"
#endif
-using std::min;
using std::max;
+using std::min;
#ifndef HLSLDATAFILEPARAM
#define HLSLDATAFILEPARAM L"HlslDataDir"
|
alsepkow
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using namespace std;is generally considered a bad practice so it should be removed anyways but this was causing downstream ambeguity errors so it needs to be fix.Completely removing is was going to cause a bunch of min/max headaches so those were added in as more precise using statements.