Skip to content

[SM6.10][HLK][Bugfix] Remove using std from common header#8358

Merged
V-FEXrt merged 2 commits intomicrosoft:mainfrom
V-FEXrt:linalg-no-std-in-header
Apr 9, 2026
Merged

[SM6.10][HLK][Bugfix] Remove using std from common header#8358
V-FEXrt merged 2 commits intomicrosoft:mainfrom
V-FEXrt:linalg-no-std-in-header

Conversation

@V-FEXrt
Copy link
Copy Markdown
Collaborator

@V-FEXrt V-FEXrt commented Apr 9, 2026

using namespace std; is generally considered a bad practice so it should be removed anyways but this was causing downstream ambeguity errors so it needs to be fix.

Completely removing is was going to cause a bunch of min/max headaches so those were added in as more precise using statements.

Copy link
Copy Markdown
Member

@jenatali jenatali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff aba4445f744167b1bced5973a57b64047a1075b8 48a54ee9e8b23bf03eb697b7b9d8ad1840a6ef77 -- include/dxc/Test/HlslTestUtils.h tools/clang/unittests/HLSLExec/ExecutionTest.cpp
View the diff from clang-format here.
diff --git a/include/dxc/Test/HlslTestUtils.h b/include/dxc/Test/HlslTestUtils.h
index 324dfa66..a6a979cd 100644
--- a/include/dxc/Test/HlslTestUtils.h
+++ b/include/dxc/Test/HlslTestUtils.h
@@ -47,8 +47,8 @@
 #include "dxc/Test/TestConfig.h"
 #endif
 
-using std::min;
 using std::max;
+using std::min;
 
 #ifndef HLSLDATAFILEPARAM
 #define HLSLDATAFILEPARAM L"HlslDataDir"
  • Check this box to apply formatting changes to this branch.

@V-FEXrt V-FEXrt merged commit e9d74b2 into microsoft:main Apr 9, 2026
10 checks passed
@github-project-automation github-project-automation Bot moved this from New to Done in HLSL Roadmap Apr 9, 2026
@V-FEXrt V-FEXrt deleted the linalg-no-std-in-header branch April 9, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants