[SM6.10][HLK][LinAlg] Address lingering feedback#8343
Merged
V-FEXrt merged 5 commits intomicrosoft:mainfrom Apr 8, 2026
Merged
[SM6.10][HLK][LinAlg] Address lingering feedback#8343V-FEXrt merged 5 commits intomicrosoft:mainfrom
V-FEXrt merged 5 commits intomicrosoft:mainfrom
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
V-FEXrt
commented
Apr 6, 2026
This move requires the following non-move changes - includes were updated - doValuesMatch were marked inline to avoid redef errors - using statements were added to LongVectors.cpp to match previous names
alsepkow
approved these changes
Apr 8, 2026
V-FEXrt
added a commit
that referenced
this pull request
Apr 8, 2026
Build on top of #8343, will move out of draft after that merges Internal feedback was provided to use the templated Load/Store methods. This PR makes that change, and then simplifies the shaders/built in defines in response to those changes. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8332
Resolve lingering feedback from the previous infrastructure PR