Skip to content

[Validation] Organize tests in LitDxilValidation by validator version #7413

@bob80905

Description

@bob80905

Is your feature request related to a problem? Please describe.
It has happened time and time again that a test that uses or produces newer DXIL does not indicate that it requires a minimum DXIL version.
For example, without ; REQUIRES: dxil-1-9, certain tests will fail when using older validators.

Describe the solution you'd like
A new file structure should be created to guarantee that by nature of a test file's location, some constraint on the minimum DXIL version is enforced. In order to check in a file, the question "What is the minimum DXIL Version?" must be answered, in order to decide the location of the test file.
As mentioned in #7408 (comment)_,
the LitDxilValidation directory will have subdirectories 1-8, 1-9, etc indicating the DXIL Version minimum requirement. Tests will be organized into these subdirectories. Each subdirectory will have a lit.cfg file that sets the minimum dxil version requirement, so that forgetting to place the requirement at the top of the test file won't cause validation failures in our internal back-compat testing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    Triaged

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions