Skip to content

Commit f915958

Browse files
Update error message per review feedback
1 parent f69c97b commit f915958

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

tools/clang/test/LitDXILValidation/outer-product-accumulate-matrix-layout-failing.ll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ target triple = "dxil-ms-dx"
1919
; an order different from the IR. So listed them here in the
2020
; order they appear and added comments for correlation
2121

22-
;CHECK: error: matrix stride must be zero for optimal layouts
23-
;CHECK: error: matrix stride must be zero for optimal layouts
22+
;CHECK: error: matrix stride must be a constant zero for optimal layouts
23+
;CHECK: error: matrix stride must be a constant zero for optimal layouts
2424
;CHECK-NOT: error: matrix layout value 'OuterProductOptimal' is not valid for outerproductaccumulate, must be 'OuterProductOptimal'
2525
;CHECK: error: matrix layout value 'MulOptimal' is not valid for outerproductaccumulate, must be 'OuterProductOptimal'
2626
;CHECK: error: matrix layout value 'ColumnMajor' is not valid for outerproductaccumulate, must be 'OuterProductOptimal'
@@ -44,9 +44,9 @@ define void @main() {
4444
call void @dx.op.outerProductAccumulate.v8f16.v8f16(i32 307, <8 x half> %6, <8 x half> %9, %dx.types.Handle %10, i32 0, i32 8, i32 1, i32 0) ; OuterProductAccumulate(inputVector1,inputVector2,matrixBuffer,matrixOffset,matrixIntepretation,matrixLayout,matrixStride)
4545
; matrix layout value 'MulOptimal' is not valid for outerproductaccumulate, must be 'OuterProductOptimal'
4646
call void @dx.op.outerProductAccumulate.v8f16.v8f16(i32 307, <8 x half> %6, <8 x half> %9, %dx.types.Handle %10, i32 0, i32 8, i32 2, i32 0) ; OuterProductAccumulate(inputVector1,inputVector2,matrixBuffer,matrixOffset,matrixIntepretation,matrixLayout,matrixStride)
47-
; error: matrix stride must be zero for optimal layouts
47+
; error: matrix stride must be a constant zero for optimal layouts
4848
call void @dx.op.outerProductAccumulate.v8f16.v8f16(i32 307, <8 x half> %6, <8 x half> %9, %dx.types.Handle %10, i32 0, i32 8, i32 3, i32 64) ; OuterProductAccumulate(inputVector1,inputVector2,matrixBuffer,matrixOffset,matrixIntepretation,matrixLayout,matrixStride)
49-
; error: matrix stride must be zero for optimal layouts
49+
; error: matrix stride must be a constant zero for optimal layouts
5050
call void @dx.op.outerProductAccumulate.v8f16.v8f16(i32 307, <8 x half> %6, <8 x half> %9, %dx.types.Handle %10, i32 0, i32 8, i32 3, i32 63) ; OuterProductAccumulate(inputVector1,inputVector2,matrixBuffer,matrixOffset,matrixIntepretation,matrixLayout,matrixStride)
5151
ret void
5252
}

utils/hct/hctdb.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8450,7 +8450,7 @@ def build_valrules(self):
84508450
self.add_valrule_msg(
84518451
"Instr.LinalgMatrixStrideZeroForOptimalLayouts",
84528452
"For optimal layouts, matrix stride must be zero.",
8453-
"matrix stride must be zero for optimal layouts",
8453+
"matrix stride must be a constant zero for optimal layouts",
84548454
)
84558455

84568456
self.add_valrule_msg(

0 commit comments

Comments
 (0)