Assert TypeDiagContext enum value compatible with unsupported_long_vector

Author: simoll

tools/clang/include/clang/Sema/SemaHLSL.h

@@ -61,6 +61,8 @@ bool DiagnoseNodeStructArgument(clang::Sema *self,
 
 // Keep this in sync with err_hlsl_unsupported_object in DiagnosticSemaKinds.td
 enum class TypeDiagContext {
+  // Supported indices for both `err_hlsl_unsupported_object_context` and
+  // `err_hlsl_unsupported_long_vector`
   ConstantBuffersOrTextureBuffers = 0,
   TessellationPatches = 1,
   GeometryStreams = 2,
@@ -74,6 +76,8 @@ enum class TypeDiagContext {
   PayloadParameters = 10,
   Attributes = 11,
   TypeParameter = 12,
+  LongVecDiagMaxSelectIndex = TypeParameter,
+  // Below only supported for `err_hlsl_diag_unsupported_object_context`
   StructuredBuffers = 13,
   GlobalVariables = 14,
   GroupShared = 15,

tools/clang/lib/Sema/SemaHLSL.cpp

@@ -12195,6 +12195,9 @@ DiagnoseElementTypes(Sema &S, SourceLocation Loc, QualType Ty, bool &Empty,
     // into this function. Could fold all context-dependent long vector checks
     // into this function.
     if (CheckLongVec && GetHLSLVecSize(Ty) > DXIL::kDefaultMaxVectorLength) {
+      DXASSERT_NOMSG(
+          DiagContextIdx <=
+          static_cast<unsigned>(TypeDiagContext::LongVecDiagMaxSelectIndex));
       S.Diag(Loc, diag::err_hlsl_unsupported_long_vector) << DiagContextIdx;
       Empty = false;
       return false;