[SM6.10] Linalg Builtin Diag on Bad Stage (#8233)

Some builtins are only allowed in a limited set of shader stages. Raise
a Sema Diag when they are improperly used.

Fixes #8229

Author: V-FEXrt

tools/clang/include/clang/Basic/DiagnosticSemaKinds.td

@@ -8055,6 +8055,9 @@ def err_hlsl_linalg_matrix_attribute_on_invalid_type
 def err_hlsl_linalg_attributed_matrix_required
     : Error<"argument must be linear algebra matrix type">;
 
+def err_hlsl_linalg_unsupported_stage : Error<
+   "builtin unavailable in shader stage '%0' (requires 'compute', 'mesh' or 'amplification')">;
+
 def err_hlsl_linalg_mul_muladd_output_vector_size_not_equal_to_matrix_M : Error<
   "output vector length must be equal to Matrix M dimension in a linalg Mul/MulAdd operation">;
 def err_hlsl_linalg_mul_muladd_unpacked_input_vector_size_not_equal_to_matrix_K : Error<

tools/clang/lib/Sema/SemaHLSL.cpp

@@ -12896,6 +12896,23 @@ static void DiagnoseReachableSERCall(Sema &S, CallExpr *CE,
   S.Diag(EntryLoc, diag::note_hlsl_entry_defined_here);
 }
 
+// Some LinAlg builtins are not available in all shader stages
+// Detect those use cases and raise a Diagnostic
+static void DiagnoseReachableLimitedLinAlgCall(Sema &S, CallExpr *CE,
+                                               DXIL::ShaderKind EntrySK,
+                                               const FunctionDecl *EntryDecl) {
+  if (EntrySK == DXIL::ShaderKind::Compute ||
+      EntrySK == DXIL::ShaderKind::Mesh ||
+      EntrySK == DXIL::ShaderKind::Amplification)
+    return;
+
+  SourceLocation EntryLoc = EntryDecl->getLocation();
+  SourceLocation Loc = CE->getExprLoc();
+  S.Diag(Loc, diag::err_hlsl_linalg_unsupported_stage)
+      << ShaderModel::FullNameFromKind(EntrySK);
+  S.Diag(EntryLoc, diag::note_hlsl_entry_defined_here);
+}
+
 // Check HLSL member call constraints for used functions.
 // locallyVisited is true if this call has been visited already from any other
 // entry function.  Used to avoid duplicate diagnostics when not dependent on
@@ -12946,6 +12963,21 @@ void Sema::DiagnoseReachableHLSLCall(CallExpr *CE, const hlsl::ShaderModel *SM,
   case hlsl::IntrinsicOp::IOP_DxMaybeReorderThread:
     DiagnoseReachableSERCall(*this, CE, EntrySK, EntryDecl, true);
     break;
+  case hlsl::IntrinsicOp::IOP___builtin_LinAlg_FillMatrix:
+  case hlsl::IntrinsicOp::IOP___builtin_LinAlg_CopyConvertMatrix:
+  case hlsl::IntrinsicOp::IOP___builtin_LinAlg_MatrixLength:
+  case hlsl::IntrinsicOp::IOP___builtin_LinAlg_MatrixGetCoordinate:
+  case hlsl::IntrinsicOp::IOP___builtin_LinAlg_MatrixGetElement:
+  case hlsl::IntrinsicOp::IOP___builtin_LinAlg_MatrixSetElement:
+  case hlsl::IntrinsicOp::IOP___builtin_LinAlg_MatrixStoreToDescriptor:
+  case hlsl::IntrinsicOp::IOP___builtin_LinAlg_MatrixLoadFromMemory:
+  case hlsl::IntrinsicOp::IOP___builtin_LinAlg_MatrixStoreToMemory:
+  case hlsl::IntrinsicOp::IOP___builtin_LinAlg_MatrixAccumulateToMemory:
+  case hlsl::IntrinsicOp::IOP___builtin_LinAlg_MatrixMatrixMultiply:
+  case hlsl::IntrinsicOp::IOP___builtin_LinAlg_MatrixMatrixMultiplyAccumulate:
+  case hlsl::IntrinsicOp::IOP___builtin_LinAlg_MatrixAccumulate:
+    DiagnoseReachableLimitedLinAlgCall(*this, CE, EntrySK, EntryDecl);
+    break;
   default:
     break;
   }