Skip to content

Commit b3d9c8a

Browse files
authored
DIA SDK lookup fixes (#3179)
- Build platform is not included generator string for VS2019; use CMAKE_GENERATOR_PLATFORM instead - Use release version of VS by default
1 parent e0d1f5d commit b3d9c8a

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

cmake/modules/FindDiaSDK.cmake

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ get_filename_component(VS_DIA_INC_PATH "${VS_PATH}/DIA SDK/include" ABSOLUTE CAC
1212
# (although the friendly name of that is C++ profiling tools). The toolset is the most likely target.
1313
set(PROGRAMFILES_X86 "ProgramFiles(x86)")
1414
execute_process(
15-
COMMAND "$ENV{${PROGRAMFILES_X86}}/Microsoft Visual Studio/Installer/vswhere.exe" -latest -prerelease -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath
15+
COMMAND "$ENV{${PROGRAMFILES_X86}}/Microsoft Visual Studio/Installer/vswhere.exe" -latest -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath
1616
OUTPUT_VARIABLE VSWHERE_LATEST
1717
ERROR_QUIET
1818
OUTPUT_STRIP_TRAILING_WHITESPACE
@@ -25,13 +25,13 @@ find_path(DIASDK_INCLUDE_DIR # Set variable DIASDK_INCLUDE_DIR
2525
DOC "path to DIA SDK header files"
2626
)
2727

28-
if (CMAKE_GENERATOR MATCHES "Visual Studio.*Win64" )
28+
if (CMAKE_GENERATOR MATCHES "Visual Studio.*Win64" OR CMAKE_GENERATOR_PLATFORM STREQUAL "x64")
2929
find_library(DIASDK_GUIDS_LIBRARY NAMES diaguids.lib
3030
HINTS ${DIASDK_INCLUDE_DIR}/../lib/amd64 )
31-
elseif (CMAKE_GENERATOR MATCHES "Visual Studio.*ARM" )
31+
elseif (CMAKE_GENERATOR MATCHES "Visual Studio.*ARM" OR CMAKE_GENERATOR_PLATFORM STREQUAL "ARM")
3232
find_library(DIASDK_GUIDS_LIBRARY NAMES diaguids.lib
3333
HINTS ${DIASDK_INCLUDE_DIR}/../lib/arm )
34-
else (CMAKE_GENERATOR MATCHES "Visual Studio.*Win64" )
34+
else (CMAKE_GENERATOR MATCHES "Visual Studio.*Win64" OR CMAKE_GENERATOR_PLATFORM STREQUAL "ARM64")
3535
find_library(DIASDK_GUIDS_LIBRARY NAMES diaguids.lib
3636
HINTS ${DIASDK_INCLUDE_DIR}/../lib )
3737
endif (CMAKE_GENERATOR MATCHES "Visual Studio.*Win64" )

0 commit comments

Comments
 (0)