hr check

Author: bob80905

include/dxc/Support/HLSLOptions.h

@@ -115,7 +115,7 @@ struct RewriterOpts {
 };
 
 enum class ValidatorSelection : int {
-  Auto,        // Try internal validator; fallback to DXIL.dll
+  Auto,        // Force internal validator (even if DXIL.dll is present)
   Internal,    // Force internal validator (even if DXIL.dll is present)
   External,    // Use DXIL.dll, failing compilation if not available
   Invalid = -1 // Invalid

tools/clang/tools/dxcompiler/dxcutil.cpp

@@ -70,11 +70,8 @@ bool CreateValidator(CComPtr<IDxcValidator> &pValidator,
     // if external was explicitly specified, but no
     // external validator could be found (no DXIL.dll), then error
     IFTBOOL(!DxilLibIsEnabled(), DXC_E_VALIDATOR_MISSING);
-    DxilLibCreateInstance(CLSID_DxcValidator, &pValidator);
+    IFT(DxilLibCreateInstance(CLSID_DxcValidator, &pValidator));
 
-    // if external was explicitly specified, but the validator
-    // failed to be created, then error.
-    IFTBOOL(pValidator, DXC_E_VALIDATOR_MISSING);
     return false;
   }