assert if hitgroup matters only

bob80905 · bob80905 · commit a6301d677769 · 2025-03-27T14:55:45.000-07:00
diff --git a/tools/clang/lib/AST/HlslTypes.cpp b/tools/clang/lib/AST/HlslTypes.cpp
@@ -694,7 +694,8 @@ bool GetHLSLSubobjectKind(clang::QualType type,
     HLSLSubObjectAttr *Attr = RD->getAttr<HLSLSubObjectAttr>();
     subobjectKind = (DXIL::SubobjectKind)Attr->getSubObjKindUint();
     hgType = (DXIL::HitGroupType)Attr->getHitGroupType();
-    DXASSERT(DXIL::IsValidHitGroupType(hgType), "invalid hit group type");
+    if (subobjectKind == DXIL::SubobjectKind::HitGroup)
+      DXASSERT(DXIL::IsValidHitGroupType(hgType), "invalid hit group type");
 
     return true;
   }

Original file line number	Diff line number	Diff line change
`@@ -694,7 +694,8 @@ bool GetHLSLSubobjectKind(clang::QualType type,`
`694`	`694`	`HLSLSubObjectAttr *Attr = RD->getAttr<HLSLSubObjectAttr>();`
`695`	`695`	`subobjectKind = (DXIL::SubobjectKind)Attr->getSubObjKindUint();`
`696`	`696`	`hgType = (DXIL::HitGroupType)Attr->getHitGroupType();`
`697`		`- DXASSERT(DXIL::IsValidHitGroupType(hgType), "invalid hit group type");`
	`697`	`+ if (subobjectKind == DXIL::SubobjectKind::HitGroup)`
	`698`	`+ DXASSERT(DXIL::IsValidHitGroupType(hgType), "invalid hit group type");`
`698`	`699`
`699`	`700`	`return true;`
`700`	`701`	`}`