Skip to content

Commit 9df4f0a

Browse files
committed
Address comments
1 parent 3fcdebd commit 9df4f0a

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

tools/clang/unittests/HLSLExec/LinAlgTests.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,9 @@ class DxilConf_SM610_LinAlg {
351351
// Matrix Vector Arithmetic
352352
TEST_METHOD(MatVecMul_Thread_16x16_F16);
353353
TEST_METHOD(MatVecMulAdd_Thread_16x16_F16);
354+
#if 0
354355
TEST_METHOD(OuterProduct_Thread_16x16_F16);
356+
#endif
355357

356358
// Query Accumulator Layout
357359
TEST_METHOD(QueryAccumLayout);
@@ -1318,6 +1320,7 @@ void DxilConf_SM610_LinAlg::MatVecMulAdd_Thread_16x16_F16() {
13181320
ComponentType::F16);
13191321
}
13201322

1323+
#if 0
13211324
static const char OuterProductShader[] = R"(
13221325
#define USE_A 0
13231326
#define SCOPE_THREAD 0
@@ -1389,7 +1392,6 @@ static void runOuterProduct(ID3D12Device *Device,
13891392
}
13901393

13911394
void DxilConf_SM610_LinAlg::OuterProduct_Thread_16x16_F16() {
1392-
/*
13931395
MatrixParams Params = {};
13941396
Params.CompType = ComponentType::F16;
13951397
Params.M = 16;
@@ -1399,10 +1401,8 @@ void DxilConf_SM610_LinAlg::OuterProduct_Thread_16x16_F16() {
13991401
Params.NumThreads = 1;
14001402
Params.Enable16Bit = true;
14011403
runOuterProduct(D3DDevice, DxcSupport, Params, VerboseLogging);
1402-
*/
1403-
hlsl_test::LogCommentFmt(L"Skipping test as not implemented");
1404-
WEX::Logging::Log::Result(WEX::Logging::TestResults::Skipped);
14051404
}
1405+
#endif
14061406

14071407
static const char QueryAccumLayoutShader[] = R"(
14081408
RWByteAddressBuffer Output : register(u0);

0 commit comments

Comments
 (0)