review feedback

Author: anupamachandra

tools/clang/include/clang/Basic/DiagnosticSemaKinds.td

@@ -8048,7 +8048,7 @@ def err_hlsl_linalg_mul_muladd_isUnsigned_for_packed_input_must_be_true : Error<
   "IsInputUnsigned must be true for packed input interpretations in linalg mul/muladd operations">;
 def err_hlsl_linalg_mul_muladd_packed_input_vector_must_be_uint : Error<
   "packed input vector type must be a 32-bit unsigned int in linalg mul/muladd operations, "
-    "packed formats uint8_t4_packed and sint8_t4_packed are not supported currently">;
+   "packed formats uint8_t4_packed and sint8_t4_packed are not supported currently">;
 
 def err_hlsl_linalg_outer_prod_acc_vector_type_mismatch : Error<
   "input vectors of outerproductaccumulate must have the same element type">;

tools/clang/lib/Sema/SemaHLSL.cpp

@@ -11682,7 +11682,7 @@ static const unsigned kMatVecMulMatrixStrideIdx = 12;
 // MatVecAdd
 const unsigned kMatVecMulAddBiasInterpretation = 15;
 
-static bool IsValidMatrixLayoutForMulandMulAddOps(unsigned Layout) {
+static bool IsValidMatrixLayoutForMulAndMulAddOps(unsigned Layout) {
   return Layout <=
          static_cast<unsigned>(DXIL::LinalgMatrixLayout::OuterProductOptimal);
 }
@@ -11897,15 +11897,15 @@ static void CheckCommonMulandMulAddParameters(Sema &S, CallExpr *CE,
 
     // Check if the isUnsigned flag setting
     if (IsInputVectorPacked) {
-      // Check that the input vector type is always uint32_t
+      // Check that the input vector element type is "32bit"
       if (!Is32Bit) {
         S.Diags.Report(
             InputVectorExpr->getExprLoc(),
             diag::err_hlsl_linalg_mul_muladd_packed_input_vector_must_be_uint);
         return;
       }
 
-      // Check that the input vector is unsigned int
+      // Check that the input vector element type is an unsigned int
       if (!InputVectorTypePtr->isUnsignedIntegerType()) {
         S.Diags.Report(
             InputVectorExpr->getExprLoc(),
@@ -12039,7 +12039,7 @@ static void CheckCommonMulandMulAddParameters(Sema &S, CallExpr *CE,
   unsigned MatrixLayoutValue = 0;
   if (MatrixLayoutExpr->isIntegerConstantExpr(MatrixLayoutExprVal, S.Context)) {
     MatrixLayoutValue = MatrixLayoutExprVal.getLimitedValue();
-    if (!IsValidMatrixLayoutForMulandMulAddOps(MatrixLayoutValue)) {
+    if (!IsValidMatrixLayoutForMulAndMulAddOps(MatrixLayoutValue)) {
       S.Diags.Report(MatrixLayoutExpr->getExprLoc(),
                      diag::err_hlsl_linalg_matrix_layout_invalid)
           << std::to_string(MatrixLayoutValue)