Address PR review: remove Hungarian notation and HLSL Change markers

- Rename bUpdated -> Updated (drop Hungarian prefix per reviewer feedback)
- Remove // HLSL Change Begin/End markers in DxilConvergent.cpp since
  the file is already HLSL-specific

Co-authored-by: Copilot <[email protected]>

Author: JoeCitizen

lib/DXIL/DxilOperations.cpp

@@ -6738,14 +6738,13 @@ Function *OP::GetOpFunc(OpCode opCode, Type *pOverloadType) {
     if (existF->getFunctionType() != pFT)
       return nullptr;
     F = existF;
-    // HLSL Change Begin - ensure attributes are set on existing functions.
+    // Ensure attributes are set on existing functions.
     if (OpProps.FuncAttr != Attribute::None &&
         !F->hasFnAttribute(OpProps.FuncAttr))
       F->addFnAttr(OpProps.FuncAttr);
     // Mark wave ops as convergent since they depend on the active lane set.
     if (IsDxilOpWave(opCode) && !F->hasFnAttribute(Attribute::Convergent))
       F->addFnAttr(Attribute::Convergent);
-    // HLSL Change End
     UpdateCache(opClass, pOverloadType, F);
     return F;
   }
@@ -6757,7 +6756,7 @@ Function *OP::GetOpFunc(OpCode opCode, Type *pOverloadType) {
   F->addFnAttr(Attribute::NoUnwind);
   if (OpProps.FuncAttr != Attribute::None)
     F->addFnAttr(OpProps.FuncAttr);
-  // HLSL Change - mark wave ops as convergent.
+  // Mark wave ops as convergent since they depend on the active lane set.
   if (IsDxilOpWave(opCode))
     F->addFnAttr(Attribute::Convergent);
 

lib/HLSL/DxilConvergent.cpp

@@ -45,25 +45,24 @@ class DxilConvergentMark : public ModulePass {
   bool runOnModule(Module &M) override {
     const ShaderModel *SM = M.GetOrCreateHLModule().GetShaderModel();
 
-    bool bUpdated = false;
+    bool Updated = false;
 
-    // HLSL Change Begin - Mark wave-sensitive HL functions as convergent.
+    // Mark wave-sensitive HL functions as convergent.
     // This prevents optimizer passes (especially JumpThreading) from
     // restructuring control flow around wave ops, which would change
     // the set of active lanes at wave op call sites.
     for (Function &F : M.functions()) {
       if (F.isDeclaration() && IsHLWaveSensitive(&F) &&
           !F.hasFnAttribute(Attribute::Convergent)) {
         F.addFnAttr(Attribute::Convergent);
-        bUpdated = true;
+        Updated = true;
       }
     }
-    // HLSL Change End
 
     // Can skip if in a shader and version that doesn't support derivatives.
     if (!SM->IsPS() && !SM->IsLib() &&
         (!SM->IsSM66Plus() || (!SM->IsCS() && !SM->IsMS() && !SM->IsAS())))
-      return bUpdated;
+      return Updated;
     SupportsVectors = SM->IsSM69Plus();
 
     for (Function &F : M.functions()) {
@@ -80,13 +79,13 @@ class DxilConvergentMark : public ModulePass {
             if (PropagateConvergent(V, &F, PDR)) {
               // TODO: emit warning here.
             }
-            bUpdated = true;
+            Updated = true;
           }
         }
       }
     }
 
-    return bUpdated;
+    return Updated;
   }
 
 private: