Skip to content

Commit 71b84cc

Browse files
committed
[lit] Simplify regex for dxil version check. (#6335)
Check dxc version and dxil version separately. (cherry picked from commit 5e658ac)
1 parent 58d9cf6 commit 71b84cc

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

tools/clang/test/LitDXILValidation/illegalDXILOp.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ define void @main() {
3939

4040
%6 = call %dx.types.Handle @dx.op.annotateHandle2(i32 216, %dx.types.Handle %2, %dx.types.ResourceProperties { i32 32782, i32 0 }) ; AnnotateHandle(res,props) resource: SamplerComparisonState
4141

42-
; CHECK: error: DXILOpCode must be [0..258]. 1999981 specified.
42+
; CHECK: error: DXILOpCode must be [0..{{[0-9]+}}]. 1999981 specified.
4343
; CHECK: note: at '%7 = call float @dx.op.calculateLOD.f32(i32 1999981, %dx.types.Handle %5, %dx.types.Handle %6, float %3, float %4, float undef, i1 true)' in block '#0' of function 'main'.
4444

4545
%7 = call float @dx.op.calculateLOD.f32(i32 1999981, %dx.types.Handle %5, %dx.types.Handle %6, float %3, float %4, float undef, i1 true) ; CalculateLOD(handle,sampler,coord0,coord1,coord2,clamped)

tools/clang/test/lit.cfg

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -507,12 +507,14 @@ if config.spirv:
507507
def get_dxil_version():
508508
result = subprocess.run([lit.util.which('dxc', llvm_tools_dir), "--version"], stdout=subprocess.PIPE)
509509
output = result.stdout.decode("utf-8")
510-
pat = re.compile(r"(dxcompiler.dll|libdxcompiler.so|libdxcompiler.dylib): (?P<dxcMajor>[0-9]+)\.(?P<dxcMinor>[0-9]+).*(; (dxil.dll|libdxil.so): (?P<dxilMajor>[0-9]+)\.(?P<dxilMinor>[0-9]+))?")
511-
m = pat.search(output)
510+
dxcPat = re.compile(r"(dxcompiler.dll|libdxcompiler.so|libdxcompiler.dylib): (?P<dxcMajor>[0-9]+)\.(?P<dxcMinor>[0-9]+).")
511+
m = dxcPat.search(output)
512512
dxcMajor = int(m.group("dxcMajor"))
513513
dxcMinor = int(m.group("dxcMinor"))
514514

515-
if None == m.group("dxilMajor"):
515+
dxilPat = re.compile(r"; (dxil.dll|libdxil.so): (?P<dxilMajor>[0-9]+)\.(?P<dxilMinor>[0-9]+)")
516+
m = dxilPat.search(output)
517+
if None == m:
516518
return dxcMajor, dxcMinor
517519
dxilMajor = int(m.group("dxilMajor"))
518520
dxilMinor = int(m.group("dxilMinor"))

0 commit comments

Comments
 (0)