Skip to content

Commit 562593a

Browse files
simolltex3d
andauthored
Apply suggestions from code review
Co-authored-by: Tex Riddell <[email protected]>
1 parent 8a6955c commit 562593a

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

lib/DxilValidation/DxilValidation.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4426,7 +4426,7 @@ static void ValidateResources(ValidationContext &ValCtx) {
44264426
StringRef Prefix = Uav->IsGloballyCoherent() ? "globally" : "reorder";
44274427
ValCtx.EmitResourceFormatError(
44284428
Uav.get(), ValidationRule::MetaCoherenceNotOnAppendConsume,
4429-
{Prefix, ValCtx.GetResourceName(Uav.get())});
4429+
{Prefix});
44304430
}
44314431

44324432
ValidateResource(*Uav, ValCtx);

tools/clang/test/LitDXILValidation/ser_reordercoherent_invalid_incdec.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
; COM: buffer.DecrementCounter();
1414
; COM: }
1515

16-
; CHECK: error: reordercoherent cannot be used with append/consume buffers: 'buffer'. 'buffer'
16+
; CHECK: error: reordercoherent cannot be used on buffer with counter 'buffer'
1717
; CHECK-NEXT: Validation failed.
1818

1919
; shader hash: 638950814a9023bf537d61dbb330a4c8

utils/hct/hctdb.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8017,7 +8017,8 @@ def build_valrules(self):
80178017
self.add_valrule("Meta.ValidSamplerMode", "Invalid sampler mode on sampler .")
80188018
self.add_valrule(
80198019
"Meta.CoherenceNotOnAppendConsume",
8020-
"%0coherent cannot be used with append/consume buffers: '%1'.",
8020+
"globally/reorder coherent incompatible with append/consume/counter buffers",
8021+
"%0coherent cannot be used on buffer with counter",
80218022
)
80228023
self.add_valrule_msg(
80238024
"Meta.StructBufAlignment",

0 commit comments

Comments
 (0)