pr-feedback: unreachable

Keenuts · Keenuts · commit 32ae71b673ef · 2026-03-25T14:25:40.000+01:00
diff --git a/tools/clang/lib/SPIRV/DeclResultIdMapper.cpp b/tools/clang/lib/SPIRV/DeclResultIdMapper.cpp
@@ -1202,7 +1202,7 @@ DeclResultIdMapper::createResourceDescriptorHeap(const VarDecl *var) {
     }
     HeapVar = SamplerHeapVar;
   } else
-    assert(0 && "Unsupported heap type");
+    llvm_unreachable("Unsupported heap type. FIXME");
 
   // Decorate with BuiltIn
   astDecls[var] = createDeclSpirvInfo(HeapVar);

Original file line number	Diff line number	Diff line change
`@@ -1202,7 +1202,7 @@ DeclResultIdMapper::createResourceDescriptorHeap(const VarDecl *var) {`
`1202`	`1202`	`}`
`1203`	`1203`	`HeapVar = SamplerHeapVar;`
`1204`	`1204`	`} else`
`1205`		`- assert(0 && "Unsupported heap type");`
	`1205`	`+ llvm_unreachable("Unsupported heap type. FIXME");`
`1206`	`1206`
`1207`	`1207`	`// Decorate with BuiltIn`
`1208`	`1208`	`astDecls[var] = createDeclSpirvInfo(HeapVar);`