Remove redundant '' around %0 in unsupported_object_context diag msg

Author: simoll

tools/clang/include/clang/Basic/DiagnosticSemaKinds.td

@@ -7886,7 +7886,7 @@ def err_hlsl_unsupported_long_vector
     "payload parameters|attributes}0 are not supported">;
 // %select options must be compatible with err_hlsl_unsupported_long_vector (same index used)
 def err_hlsl_unsupported_object_context
-    : Error<"object '%0' is not allowed in "
+    : Error<"object %0 is not allowed in "
     "%select{ConstantBuffers or TextureBuffers|"
     "tessellation patches|geometry streams|node records|"
     "cbuffers or tbuffers|user-defined struct parameter|"

tools/clang/test/SemaHLSL/hlsl/objects/HitObject/hitobject-in-buffer.hlsl

@@ -1,4 +1,4 @@
 // RUN: %dxc -T lib_6_9 %s -verify
 
-// expected-error@+1{{object ''dx::HitObject'' is not allowed in structured buffers}}
+// expected-error@+1{{object 'dx::HitObject' is not allowed in structured buffers}}
 RWStructuredBuffer<dx::HitObject> InvalidBuffer;

tools/clang/test/SemaHLSL/hlsl/objects/HitObject/hitobject_traceinvoke_payload_udt.hlsl

@@ -16,7 +16,7 @@ struct Attribs
 [shader("raygeneration")]
 void RayGen()
 {
-  // expected-error@+2{{object ''dx::HitObject'' is not allowed in payload parameters}}
+  // expected-error@+2{{object 'dx::HitObject' is not allowed in payload parameters}}
   // expected-note@8{{'dx::HitObject' field declared here}}
   Payload payload_in_rg;
   dx::HitObject::Invoke( dx::HitObject(), payload_in_rg );

tools/clang/test/SemaHLSL/hlsl/types/invalid-hitobject-decls-hs.hlsl

@@ -12,12 +12,12 @@ struct LongVec {
 
 HsConstantData
 PatchConstantFunction(
-    // expected-error@-1{{object ''dx::HitObject'' is not allowed in patch constant function return type}}
+    // expected-error@-1{{object 'dx::HitObject' is not allowed in patch constant function return type}}
     // expected-note@5{{'dx::HitObject' field declared here}}
 	  dx::HitObject hit : V,
-    // expected-error@-1{{object ''dx::HitObject'' is not allowed in patch constant function parameters}}
+    // expected-error@-1{{object 'dx::HitObject' is not allowed in patch constant function parameters}}
 	  LongVec lv : L)
-    // expected-error@-1{{object ''dx::HitObject'' is not allowed in patch constant function parameters}}
+    // expected-error@-1{{object 'dx::HitObject' is not allowed in patch constant function parameters}}
     // expected-note@10{{'dx::HitObject' field declared here}}
 {
   HsConstantData empty;

tools/clang/test/SemaHLSL/hlsl/types/invalid-hitobject-decls-struct.hlsl

@@ -76,7 +76,7 @@ void node07(RWThreadNodeInputRecord<f2x2> input) // expected-error {{'f2x2' (aka
 
 [Shader("node")]
 [NodeLaunch("thread")]
-void node08(ThreadNodeInputRecord<BAD_RECORD> input) // expected-error {{object ''SamplerState'' is not allowed in node records}}
+void node08(ThreadNodeInputRecord<BAD_RECORD> input) // expected-error {{object 'SamplerState' is not allowed in node records}}
 { }
 
 [Shader("node")]
@@ -86,17 +86,17 @@ void node09(ThreadNodeInputRecord<BAD_RECORD[4]> input) // expected-error {{'BAD
 
 [Shader("node")]
 [NodeLaunch("thread")]
-void node10(RWThreadNodeInputRecord<BAD_RECORD2> input) // expected-error {{object ''SamplerState'' is not allowed in node records}}
+void node10(RWThreadNodeInputRecord<BAD_RECORD2> input) // expected-error {{object 'SamplerState' is not allowed in node records}}
 { }
 
 [Shader("node")]
 [NodeLaunch("thread")]
-void node11(NodeOutput<BAD_RECORD> input) // expected-error {{object ''SamplerState'' is not allowed in node records}}
+void node11(NodeOutput<BAD_RECORD> input) // expected-error {{object 'SamplerState' is not allowed in node records}}
 { }
 
 [Shader("node")]
 [NodeLaunch("thread")]
-void node12(NodeOutputArray<MyBadRecord> output) // expected-error {{object ''SamplerState'' is not allowed in node records}}
+void node12(NodeOutputArray<MyBadRecord> output) // expected-error {{object 'SamplerState' is not allowed in node records}}
 { }
 
 [Shader("node")]
@@ -129,7 +129,7 @@ void node16()
 
   ThreadNodeOutputRecords<f2x2> outrec2; // expected-error {{'f2x2' (aka 'matrix<float, 2, 2>') is not valid as a node record type - struct/class required}}
 
-  GroupNodeOutputRecords<MyBadRecord> outrec3; // expected-error {{object ''SamplerState'' is not allowed in node records}}
+  GroupNodeOutputRecords<MyBadRecord> outrec3; // expected-error {{object 'SamplerState' is not allowed in node records}}
 
   ThreadNodeOutputRecords<SamplerState> outrec4; // expected-error {{'SamplerState' is not valid as a node record type - struct/class required}}
 }
@@ -151,10 +151,10 @@ void node17(ThreadNodeInputRecord<MyTemplateStruct<int> > input)
 
 [Shader("node")]
 [NodeLaunch("thread")]
-void node18(ThreadNodeInputRecord<MyTemplateStruct<SamplerState> > input) // expected-error {{object ''SamplerState'' is not allowed in node records}}
+void node18(ThreadNodeInputRecord<MyTemplateStruct<SamplerState> > input) // expected-error {{object 'SamplerState' is not allowed in node records}}
 { }
 
 [Shader("node")]
 [NodeLaunch("thread")]
-void node19(RWThreadNodeInputRecord<MyNestedTemplateStruct> input) // expected-error {{object ''SamplerState'' is not allowed in node records}}
+void node19(RWThreadNodeInputRecord<MyNestedTemplateStruct> input) // expected-error {{object 'SamplerState' is not allowed in node records}}
 { }

tools/clang/test/SemaHLSL/hlsl/types/invalid-hitobject-decls-templated.hlsl

@@ -1,8 +1,8 @@
 // RUN: %dxc -Tlib_6_3 -verify %s
 
 Texture2D<float4> t_float4;
-Texture2D<SamplerState> t_obj_sampler;          /* expected-error {{object ''SamplerState'' is not allowed in type parameters}} fxc-error {{X3124: object element type cannot be an object type}} */
-Texture2D<Texture2D<float4> > t_obj_tex;        /* expected-error {{object ''Texture2D<float4>'' is not allowed in type parameters}} fxc-error {{X3124: object element type cannot be an object type}} */
+Texture2D<SamplerState> t_obj_sampler;          /* expected-error {{object 'SamplerState' is not allowed in type parameters}} fxc-error {{X3124: object element type cannot be an object type}} */
+Texture2D<Texture2D<float4> > t_obj_tex;        /* expected-error {{object 'Texture2D<float4>' is not allowed in type parameters}} fxc-error {{X3124: object element type cannot be an object type}} */
 
 matrix<SamplerState, 1, 2> m_obj_sampler;       /* expected-error {{'SamplerState' cannot be used as a type parameter where a scalar is required}} fxc-error {{X3123: matrix element type must be a scalar type}} */
 matrix<bool, 1, 2> m_bool;
@@ -15,7 +15,7 @@ matrix<bool, 1, 2> m_bool;
 
 RWBuffer<double3> rwb_struct;    /* expected-error {{elements of typed buffers and textures must fit in four 32-bit quantities}} fxc-error {{X3037: elements of typed buffers and textures must fit in four 32-bit quantities}} */
 
-RWBuffer<SamplerState> rwb_struct_objs; /* expected-error {{object ''SamplerState'' is not allowed in type parameters}} */
+RWBuffer<SamplerState> rwb_struct_objs; /* expected-error {{object 'SamplerState' is not allowed in type parameters}} */
 
 void vain() {
   // Nothing to do here.