Skip to content

Commit 2a31dcb

Browse files
committed
clean up test
1 parent e87888d commit 2a31dcb

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

tools/clang/test/HLSLFileCheck/infra/auto-dxilver.hlsl

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,17 @@
55
// This should implicitly require dxilver 1.8.
66

77
// RUN: %dxc -T vs_6_8 -Vd %s | FileCheck %s
8-
// Even though this is using -Vd, the validator version is set by the available
9-
// validator. If that isn't version 1.8 or above, we'll see an error.
8+
// Even though this is using -Vd, the validator version being checked is the internal
9+
// validator's version. If a pre-DXIL-1.8 DXC was used to run this test, we expect failure,
10+
// since the internal validator will be the same version as the older DXC.
1011
// The implicit dxilver logic should not skip the check when -Vd is used.
1112
// CHECK-NOT: error: validator version {{.*}} does not support target profile.
1213

1314
// RUN: %dxc -T vs_6_0 -validator-version 1.8 %s | FileCheck %s
1415
// Even though target is 6.0, the explicit -validator-version should add an
15-
// implicit dxilver 1.8 requirement.
16+
// implicit dxilver 1.8 requirement. The requirement should pass for DXCs that
17+
// are newer than DXIL Version 1.8, since then, the internal validator's version will
18+
// be sufficiently new for this check.
1619
// CHECK-NOT: error: The module cannot be validated by the version of the validator currently attached.
1720

1821
// This error would occur if run against wrong compiler.
@@ -21,8 +24,6 @@
2124
// Catch any other unexpected error cases.
2225
// CHECK-NOT: error
2326

24-
// RUN: %dxc -T vs_6_8 %s | FileCheck %s
25-
// This should always be run, and always succeed.
2627
// CHECK: define void @main()
2728

2829
void main() {}

0 commit comments

Comments
 (0)