|
5 | 5 | // This should implicitly require dxilver 1.8. |
6 | 6 |
|
7 | 7 | // RUN: %dxc -T vs_6_8 -Vd %s | FileCheck %s |
8 | | -// Even though this is using -Vd, the validator version is set by the available |
9 | | -// validator. If that isn't version 1.8 or above, we'll see an error. |
| 8 | +// Even though this is using -Vd, the validator version being checked is the internal |
| 9 | +// validator's version. If a pre-DXIL-1.8 DXC was used to run this test, we expect failure, |
| 10 | +// since the internal validator will be the same version as the older DXC. |
10 | 11 | // The implicit dxilver logic should not skip the check when -Vd is used. |
11 | 12 | // CHECK-NOT: error: validator version {{.*}} does not support target profile. |
12 | 13 |
|
13 | 14 | // RUN: %dxc -T vs_6_0 -validator-version 1.8 %s | FileCheck %s |
14 | 15 | // Even though target is 6.0, the explicit -validator-version should add an |
15 | | -// implicit dxilver 1.8 requirement. |
| 16 | +// implicit dxilver 1.8 requirement. The requirement should pass for DXCs that |
| 17 | +// are newer than DXIL Version 1.8, since then, the internal validator's version will |
| 18 | +// be sufficiently new for this check. |
16 | 19 | // CHECK-NOT: error: The module cannot be validated by the version of the validator currently attached. |
17 | 20 |
|
18 | 21 | // This error would occur if run against wrong compiler. |
|
21 | 24 | // Catch any other unexpected error cases. |
22 | 25 | // CHECK-NOT: error |
23 | 26 |
|
24 | | -// RUN: %dxc -T vs_6_8 %s | FileCheck %s |
25 | | -// This should always be run, and always succeed. |
26 | 27 | // CHECK: define void @main() |
27 | 28 |
|
28 | 29 | void main() {} |
0 commit comments