Skip to content

Commit 1c71260

Browse files
committed
Fix Typo in PTRBITCAST
update the docs, tests and update hctdb.py so that InstrPtrBitCast in DxilValidation.inc & DxilValidationImpl.inc have the new error message
1 parent 231d648 commit 1c71260

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

docs/DXIL.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3174,7 +3174,7 @@ INSTR.OPCONST DXIL intrinsic requires an
31743174
INSTR.OPCONSTRANGE Constant values must be in-range for operation.
31753175
INSTR.OPERANDRANGE DXIL intrinsic operand must be within defined range
31763176
INSTR.PARAMMULTIPLE Parameter must be a valid multiple
3177-
INSTR.PTRBITCAST Pointer type bitcast must be have same size.
3177+
INSTR.PTRBITCAST Pointer type bitcast must have same size.
31783178
INSTR.RESOURCECLASSFORLOAD load can only run on UAV/SRV resource.
31793179
INSTR.RESOURCECLASSFORSAMPLERGATHER sample, lod and gather should be on srv resource.
31803180
INSTR.RESOURCECLASSFORUAVSTORE store should be on uav resource.

tools/clang/unittests/HLSL/ValidationTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1724,7 +1724,7 @@ TEST_F(ValidationTest, PtrBitCast) {
17241724
"%\\1 = getelementptr [4 x i32], [4 x i32]* %\\2, i32 0, i32 0\n"
17251725
" %X = bitcast i32* %\\1 to double* \n"
17261726
" store i32 %\\3, i32* %\\1, align 4",
1727-
"Pointer type bitcast must be have same size",
1727+
"Pointer type bitcast must have same size",
17281728
/*bRegex*/ true);
17291729
}
17301730

utils/hct/hctdb.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8068,7 +8068,7 @@ def build_valrules(self):
80688068
"Call to DXIL intrinsic '%0' does not match an allowed overload signature.",
80698069
)
80708070
self.add_valrule(
8071-
"Instr.PtrBitCast", "Pointer type bitcast must be have same size."
8071+
"Instr.PtrBitCast", "Pointer type bitcast must have same size."
80728072
)
80738073
self.add_valrule(
80748074
"Instr.MinPrecisonBitCast", "Bitcast on minprecison types is not allowed."

0 commit comments

Comments
 (0)