Skip to content

Commit 0ef9b70

Browse files
authored
[SPIR-V] Error when -Gis is used with -spirv (#4529)
Though we may support -Gis with the SPIR-V backend in future, it is currently not supported, so this change makes that explicit to the user with an error message when it is used. Related to #3331
1 parent a19c326 commit 0ef9b70

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

lib/DxcSupport/HLSLOptions.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ static bool hasUnsupportedSpirvOption(const InputArgList &args,
329329
// available options and their current compatibility is needed to generate a
330330
// complete list.
331331
std::vector<OptSpecifier> unsupportedOpts = {OPT_Fd, OPT_Fre,
332-
OPT_Qstrip_reflect};
332+
OPT_Qstrip_reflect, OPT_Gis};
333333

334334
for (const auto &id : unsupportedOpts) {
335335
if (Arg *arg = args.getLastArg(id)) {
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
// RUN: %dxc -T ps_6_0 -E main -spirv -Gis
2+
3+
void main() {}
4+
5+
// CHECK: -Gis is not supported with -spirv

0 commit comments

Comments
 (0)