Skip to content

Commit 2ff8942

Browse files
(Lookup): change naming convention to xxxRenderer
1 parent ffd9a80 commit 2ff8942

2 files changed

Lines changed: 36 additions & 36 deletions

File tree

src/scripts/Lookup.tsx

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -745,12 +745,12 @@ type LookupDropdownProps = {
745745
loading?: boolean;
746746
listboxId: string;
747747
dropdownRef: Ref<HTMLDivElement>;
748-
listHeader?: (
749-
optionProps: React.HTMLAttributes<HTMLDivElement>
748+
listHeaderRenderer?: (
749+
rendererProps: React.HTMLAttributes<HTMLDivElement>
750750
) => JSX.Element;
751751
listHeaderIdSeed: string;
752-
listFooter?: (
753-
optionProps: React.HTMLAttributes<HTMLDivElement>
752+
listFooterRenderer?: (
753+
rendererProps: React.HTMLAttributes<HTMLDivElement>
754754
) => JSX.Element;
755755
listFooterIdSeed: string;
756756
filteredData: LookupEntry[];
@@ -771,9 +771,9 @@ const LookupDropdown: FC<LookupDropdownProps> = ({
771771
loading,
772772
listboxId,
773773
dropdownRef,
774-
listHeader,
774+
listHeaderRenderer,
775775
listHeaderIdSeed,
776-
listFooter,
776+
listFooterRenderer,
777777
listFooterIdSeed,
778778
filteredData,
779779
focusedValue,
@@ -798,15 +798,15 @@ const LookupDropdown: FC<LookupDropdownProps> = ({
798798
dropdownRef={dropdownRef}
799799
{...injectedProps}
800800
>
801-
{listHeader ? (
801+
{listHeaderRenderer ? (
802802
<ul
803803
className='slds-listbox slds-listbox_vertical'
804804
role='presentation'
805805
onKeyDown={onKeyDown}
806806
onBlur={onBlur}
807807
>
808808
<li role='presentation' className='slds-listbox__item'>
809-
{listHeader({
809+
{listHeaderRenderer({
810810
id: getOptionId(listHeaderIdSeed),
811811
className: 'slds-listbox__option',
812812
role: 'option',
@@ -841,15 +841,15 @@ const LookupDropdown: FC<LookupDropdownProps> = ({
841841
</li>
842842
) : null}
843843
</ul>
844-
{listFooter ? (
844+
{listFooterRenderer ? (
845845
<ul
846846
className='slds-listbox slds-listbox_vertical'
847847
role='presentation'
848848
onKeyDown={onKeyDown}
849849
onBlur={onBlur}
850850
>
851851
<li role='presentation' className='slds-listbox__item'>
852-
{listFooter({
852+
{listFooterRenderer({
853853
id: getOptionId(listFooterIdSeed),
854854
className: 'slds-listbox__option',
855855
role: 'option',
@@ -935,11 +935,11 @@ export type LookupProps = {
935935
lookupFilter?: Bivariant<
936936
(entry: LookupEntry, searchText?: string, scope?: string) => boolean
937937
>;
938-
listHeader?: (
939-
optionProps: React.HTMLAttributes<HTMLDivElement>
938+
listHeaderRenderer?: (
939+
rendererProps: React.HTMLAttributes<HTMLDivElement>
940940
) => JSX.Element;
941-
listFooter?: (
942-
optionProps: React.HTMLAttributes<HTMLDivElement>
941+
listFooterRenderer?: (
942+
rendererProps: React.HTMLAttributes<HTMLDivElement>
943943
) => JSX.Element;
944944
tooltip?: ReactNode;
945945
tooltipIcon?: string;
@@ -991,8 +991,8 @@ export const Lookup = createFC<LookupProps, { isFormElement: boolean }>(
991991
disabled,
992992
loading,
993993
lookupFilter,
994-
listHeader,
995-
listFooter,
994+
listHeaderRenderer,
995+
listFooterRenderer,
996996
data = [],
997997
tooltip,
998998
tooltipIcon,
@@ -1068,18 +1068,18 @@ export const Lookup = createFC<LookupProps, { isFormElement: boolean }>(
10681068
? data.filter((entry) => lookupFilter(entry, searchText, targetScope))
10691069
: data;
10701070
return [
1071-
listHeader ? listHeaderIdSeed : undefined,
1071+
listHeaderRenderer ? listHeaderIdSeed : undefined,
10721072
...filteredData.map((entry) => entry.value),
1073-
listFooter ? listFooterIdSeed : undefined,
1073+
listFooterRenderer ? listFooterIdSeed : undefined,
10741074
].filter((value) => value !== undefined);
10751075
}, [
10761076
data,
10771077
lookupFilter,
10781078
searchText,
10791079
targetScope,
1080-
listHeader,
1080+
listHeaderRenderer,
10811081
listHeaderIdSeed,
1082-
listFooter,
1082+
listFooterRenderer,
10831083
listFooterIdSeed,
10841084
]);
10851085

@@ -1425,9 +1425,9 @@ export const Lookup = createFC<LookupProps, { isFormElement: boolean }>(
14251425
loading={loading}
14261426
listboxId={listboxId}
14271427
dropdownRef={dropdownRef}
1428-
listHeader={listHeader}
1428+
listHeaderRenderer={listHeaderRenderer}
14291429
listHeaderIdSeed={listHeaderIdSeed}
1430-
listFooter={listFooter}
1430+
listFooterRenderer={listFooterRenderer}
14311431
listFooterIdSeed={listFooterIdSeed}
14321432
filteredData={filteredData}
14331433
focusedValue={focusedValue}
@@ -1473,9 +1473,9 @@ export const Lookup = createFC<LookupProps, { isFormElement: boolean }>(
14731473
loading={loading}
14741474
listboxId={listboxId}
14751475
dropdownRef={dropdownRef}
1476-
listHeader={listHeader}
1476+
listHeaderRenderer={listHeaderRenderer}
14771477
listHeaderIdSeed={listHeaderIdSeed}
1478-
listFooter={listFooter}
1478+
listFooterRenderer={listFooterRenderer}
14791479
listFooterIdSeed={listFooterIdSeed}
14801480
filteredData={filteredData}
14811481
focusedValue={focusedValue}

stories/Lookup.stories.tsx

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -374,11 +374,11 @@ export const OpenedWithListHeaderFooter: ComponentStoryObj<typeof Lookup> = {
374374
opened: true,
375375
data: COMPANY_DATA,
376376
selected: null,
377-
listHeader: (optionProps) => (
377+
listHeaderRenderer: (rendererProps) => (
378378
<div
379-
{...optionProps}
379+
{...rendererProps}
380380
className={classnames(
381-
optionProps.className,
381+
rendererProps.className,
382382
'slds-listbox__option_term slds-media slds-media_center'
383383
)}
384384
>
@@ -392,11 +392,11 @@ export const OpenedWithListHeaderFooter: ComponentStoryObj<typeof Lookup> = {
392392
</span>
393393
</div>
394394
),
395-
listFooter: (optionProps) => (
395+
listFooterRenderer: (rendererProps) => (
396396
<div
397-
{...optionProps}
397+
{...rendererProps}
398398
className={classnames(
399-
optionProps.className,
399+
rendererProps.className,
400400
'slds-listbox__option_entity slds-media slds-media_center'
401401
)}
402402
>
@@ -480,11 +480,11 @@ export const DefaultOpenedWithListHeaderFooter: ComponentStoryObj<
480480
defaultOpened: true,
481481
data: COMPANY_DATA,
482482
selected: null,
483-
listHeader: (optionProps) => (
483+
listHeaderRenderer: (rendererProps) => (
484484
<div
485-
{...optionProps}
485+
{...rendererProps}
486486
className={classnames(
487-
optionProps.className,
487+
rendererProps.className,
488488
'slds-listbox__option_term slds-media slds-media_center'
489489
)}
490490
>
@@ -498,11 +498,11 @@ export const DefaultOpenedWithListHeaderFooter: ComponentStoryObj<
498498
</span>
499499
</div>
500500
),
501-
listFooter: (optionProps) => (
501+
listFooterRenderer: (rendererProps) => (
502502
<div
503-
{...optionProps}
503+
{...rendererProps}
504504
className={classnames(
505-
optionProps.className,
505+
rendererProps.className,
506506
'slds-listbox__option_entity slds-media slds-media_center'
507507
)}
508508
>

0 commit comments

Comments
 (0)