Skip to content

Commit f470438

Browse files
committed
Remove useless instance of ToggleThemeButton
1 parent 34452f5 commit f470438

2 files changed

Lines changed: 38 additions & 78 deletions

File tree

packages/ra-ui-materialui/src/layout/Menu.stories.tsx

Lines changed: 31 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -2,33 +2,14 @@ import * as React from 'react';
22

33
import { Resource, testDataProvider } from 'ra-core';
44
import { defaultTheme, Admin } from 'react-admin';
5-
import { AppBar, Typography, Box } from '@mui/material';
6-
import { createTheme } from '@mui/material/styles';
7-
import { ToggleThemeButton } from '../button';
8-
import { Layout, Menu, SidebarToggleButton, Title } from '.';
5+
import { Typography, ThemeOptions } from '@mui/material';
6+
import { Layout, Menu, Title } from '.';
97

108
export default { title: 'ra-ui-materialui/layout/Menu' };
119

1210
const resources = ['Posts', 'Comments', 'Tags', 'Users', 'Orders', 'Reviews'];
1311

14-
const DemoAppBar = () => {
15-
const darkTheme = createTheme({
16-
palette: { mode: 'dark' },
17-
});
18-
return (
19-
<AppBar elevation={1} sx={{ flexDirection: 'row', flexWrap: 'nowrap' }}>
20-
<Box sx={{ flex: '1 1 100%' }}>
21-
<SidebarToggleButton />
22-
</Box>
23-
<Box sx={{ flex: '0 0 auto' }}>
24-
<ToggleThemeButton
25-
lightTheme={defaultTheme}
26-
darkTheme={darkTheme}
27-
/>
28-
</Box>
29-
</AppBar>
30-
);
31-
};
12+
const darkTheme: ThemeOptions = { ...defaultTheme, palette: { mode: 'dark' } };
3213

3314
const DemoList = ({ name }) => (
3415
<>
@@ -38,47 +19,43 @@ const DemoList = ({ name }) => (
3819
);
3920

4021
export const Default = () => {
41-
const DefaultLayout = props => (
42-
<Layout {...props} menu={MenuDefault} appBar={DemoAppBar} />
43-
);
44-
const MenuDefault = () => {
45-
return <Menu hasDashboard={true} dense={false} />;
46-
};
22+
const MenuDefault = () => <Menu hasDashboard={true} dense={false} />;
23+
const DefaultLayout = props => <Layout {...props} menu={MenuDefault} />;
4724

4825
return (
49-
<Admin dataProvider={testDataProvider()} layout={DefaultLayout}>
50-
{resources.map((resource, index) => {
51-
return (
52-
<Resource
53-
name={resource}
54-
key={`resource_${index}`}
55-
list={<DemoList name={resource} />}
56-
/>
57-
);
58-
})}
26+
<Admin
27+
dataProvider={testDataProvider()}
28+
layout={DefaultLayout}
29+
darkTheme={darkTheme}
30+
>
31+
{resources.map((resource, index) => (
32+
<Resource
33+
name={resource}
34+
key={`resource_${index}`}
35+
list={<DemoList name={resource} />}
36+
/>
37+
))}
5938
</Admin>
6039
);
6140
};
6241

6342
export const Dense = () => {
64-
const LayoutDense = props => (
65-
<Layout {...props} menu={MenuDense} appBar={DemoAppBar} />
66-
);
67-
const MenuDense = props => {
68-
return <Menu {...props} hasDashboard={true} dense={true} />;
69-
};
43+
const MenuDense = props => <Menu hasDashboard={true} dense={true} />;
44+
const LayoutDense = props => <Layout {...props} menu={MenuDense} />;
7045

7146
return (
72-
<Admin dataProvider={testDataProvider()} layout={LayoutDense}>
73-
{resources.map((resource, index) => {
74-
return (
75-
<Resource
76-
name={resource}
77-
key={`resource_${index}`}
78-
list={<DemoList name={resource} />}
79-
/>
80-
);
81-
})}
47+
<Admin
48+
dataProvider={testDataProvider()}
49+
layout={LayoutDense}
50+
darkTheme={darkTheme}
51+
>
52+
{resources.map((resource, index) => (
53+
<Resource
54+
name={resource}
55+
key={`resource_${index}`}
56+
list={<DemoList name={resource} />}
57+
/>
58+
))}
8259
</Admin>
8360
);
8461
};

packages/ra-ui-materialui/src/list/filter/SavedQueriesList.stories.tsx

Lines changed: 7 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,11 @@ import merge from 'lodash/merge';
33

44
import {
55
Admin,
6-
AppBar,
76
defaultTheme,
8-
Layout,
9-
LayoutProps,
107
Resource,
118
Datagrid,
129
List,
1310
TextField,
14-
TitlePortal,
1511
NumberField,
1612
DateField,
1713
FilterList,
@@ -26,7 +22,6 @@ import frenchMessages from 'ra-language-french';
2622
import { createMemoryHistory } from 'history';
2723

2824
import { SavedQueriesList } from './SavedQueriesList';
29-
import { LocalesMenuButton, ToggleThemeButton } from '../../button';
3025
import { RaThemeOptions } from '../..';
3126
import fakeRestProvider from 'ra-data-fakerest';
3227

@@ -185,8 +180,13 @@ const i18nProvider = polyglotI18nProvider(
185180
locale === 'fr'
186181
? merge(frenchMessages, frenchAppMessages)
187182
: englishMessages,
188-
'en' // Default locale
183+
'en', // Default locale
184+
[
185+
{ locale: 'en', name: 'English' },
186+
{ locale: 'fr', name: 'Français' },
187+
]
189188
);
189+
190190
const darkTheme: RaThemeOptions = {
191191
...defaultTheme,
192192
palette: {
@@ -200,29 +200,12 @@ const darkTheme: RaThemeOptions = {
200200
},
201201
};
202202

203-
const MyAppBar = () => (
204-
<AppBar>
205-
<TitlePortal />
206-
<ToggleThemeButton lightTheme={defaultTheme} darkTheme={darkTheme} />
207-
<LocalesMenuButton
208-
languages={[
209-
{ locale: 'en', name: 'English' },
210-
{ locale: 'fr', name: 'Français' },
211-
]}
212-
/>
213-
</AppBar>
214-
);
215-
216-
const MyLayout = (props: LayoutProps) => (
217-
<Layout {...props} appBar={MyAppBar} />
218-
);
219-
220203
export const WithThemeAndLocale = () => (
221204
<Admin
222205
history={createMemoryHistory()}
223206
i18nProvider={i18nProvider}
224207
dataProvider={dataProvider}
225-
layout={MyLayout}
208+
darkTheme={darkTheme}
226209
>
227210
<Resource name="songs" list={SongList} />
228211
</Admin>

0 commit comments

Comments
 (0)