Users: A11y: Improve title attributes in author link functions.

Remove the title attribute from `the_author_posts_link()` and related functions, retaining text for use in `the_author_posts_link` filter, and add parameter to disable title attributes in `the_author_link()`. 

Default behavior will still differentiate the two links, but adds the option to remove all title attributes.

Props sabernhardt, alh0319, adnanlimdi, audrasjb, joedolson.
Fixes #62835. See #26559.
Built from https://develop.svn.wordpress.org/trunk@61745


git-svn-id: http://core.svn.wordpress.org/trunk@61051 1a063a9b-81f0-0310-95a4-ce76da25c4cd

Author: joedolson

wp-includes/author-template.php

@@ -229,24 +229,29 @@ function the_author_meta( $field = '', $user_id = false ) {
  * the author's name.
  *
  * @since 3.0.0
+ * @since 7.0.0 Added `$use_title_attr` parameter.
  *
  * @global WP_User $authordata The current author's data.
  *
+ * @param bool $use_title_attr Optional. Whether to add a title attribute.
+ *                             Default true.
  * @return string An HTML link if the author's URL exists in user meta,
  *                otherwise the result of get_the_author().
  */
-function get_the_author_link() {
+function get_the_author_link( $use_title_attr = true ) {
 	if ( get_the_author_meta( 'url' ) ) {
 		global $authordata;
 
 		$author_url          = get_the_author_meta( 'url' );
 		$author_display_name = get_the_author();
 
+		/* translators: %s: Author's display name. */
+		$author_title = sprintf( __( 'Visit %s’s website' ), $author_display_name );
+
 		$link = sprintf(
-			'<a href="%1$s" title="%2$s" rel="author external">%3$s</a>',
+			'<a href="%1$s"%2$s rel="author external">%3$s</a>',
 			esc_url( $author_url ),
-			/* translators: %s: Author's display name. */
-			esc_attr( sprintf( __( 'Visit %s&#8217;s website' ), $author_display_name ) ),
+			$use_title_attr ? ' title="' . esc_attr( $author_title ) . '"' : '',
 			$author_display_name
 		);
 
@@ -274,9 +279,13 @@ function get_the_author_link() {
  * @link https://developer.wordpress.org/reference/functions/the_author_link/
  *
  * @since 2.1.0
+ * @since 7.0.0 Added `$use_title_attr` parameter.
+ *
+ * @param bool $use_title_attr Optional. Whether to add a title attribute.
+ *                             Default true.
  */
-function the_author_link() {
-	echo get_the_author_link();
+function the_author_link( $use_title_attr = true ) {
+	echo get_the_author_link( $use_title_attr );
 }
 
 /**
@@ -310,6 +319,7 @@ function the_author_posts() {
  * Returns an HTML-formatted link using get_author_posts_url().
  *
  * @since 4.4.0
+ * @since 7.0.0 Removed title attribute.
  *
  * @global WP_User $authordata The current author's data.
  *
@@ -322,22 +332,27 @@ function get_the_author_posts_link() {
 		return '';
 	}
 
+	$author = get_the_author();
+	/* translators: %s: Author's display name. */
+	$title  = sprintf( __( 'Posts by %s' ), $author );
+
 	$link = sprintf(
-		'<a href="%1$s" title="%2$s" rel="author">%3$s</a>',
+		'<a href="%1$s" rel="author">%2$s</a>',
 		esc_url( get_author_posts_url( $authordata->ID, $authordata->user_nicename ) ),
-		/* translators: %s: Author's display name. */
-		esc_attr( sprintf( __( 'Posts by %s' ), get_the_author() ) ),
-		get_the_author()
+		$author
 	);
 
 	/**
 	 * Filters the link to the author page of the author of the current post.
 	 *
 	 * @since 2.9.0
+	 * @since 7.0.0 Added `$author` and `$title` parameters.
 	 *
-	 * @param string $link HTML link.
+	 * @param string $link   HTML link.
+	 * @param string $author Author's display name.
+	 * @param string $title  Text originally used for a title attribute.
 	 */
-	return apply_filters( 'the_author_posts_link', $link );
+	return apply_filters( 'the_author_posts_link', $link, $author, $title );
 }
 
 /**
@@ -536,10 +551,8 @@ function wp_list_authors( $args = '' ) {
 		}
 
 		$link = sprintf(
-			'<a href="%1$s" title="%2$s">%3$s</a>',
+			'<a href="%1$s">%2$s</a>',
 			esc_url( get_author_posts_url( $author->ID, $author->user_nicename ) ),
-			/* translators: %s: Author's display name. */
-			esc_attr( sprintf( __( 'Posts by %s' ), $author->display_name ) ),
 			$name
 		);
 

wp-includes/version.php

@@ -16,7 +16,7 @@
  *
  * @global string $wp_version
  */
-$wp_version = '7.0-beta1-61744';
+$wp_version = '7.0-beta1-61745';
 
 /**
  * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.