Skip to content

Commit 2797bb3

Browse files
committed
Administration: Fix plugin and theme installer buttons.
Plugin and theme installer buttons load a dashicon during their updating and updated states. These dashicons were sized to large buttons, and caused a shift in alignment after the switch to compact buttons. Update CSS to prevent shifts in size and alignment for installer buttons. Props mohitbsf, peterwilsoncc, adnanhyder, huzaifaalmesbah, noruzzaman, ravichudasama01, shailu25, r1k0, joedolson. Fixes #64687. Built from https://develop.svn.wordpress.org/trunk@61741 git-svn-id: http://core.svn.wordpress.org/trunk@61047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
1 parent d52c550 commit 2797bb3

9 files changed

Lines changed: 41 additions & 5 deletions

File tree

wp-admin/css/list-tables-rtl.css

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1453,6 +1453,14 @@ ul.cat-checklist input[name="post_category[]"]:indeterminate::before {
14531453
content: "\f147" / '';
14541454
}
14551455

1456+
.plugin-card .updated-message:before,
1457+
.plugin-card .updating-message:before {
1458+
line-height: 1;
1459+
position: relative;
1460+
top: -2px;
1461+
vertical-align: middle;
1462+
}
1463+
14561464
.plugin-install-php #the-list {
14571465
display: flex;
14581466
flex-wrap: wrap;

wp-admin/css/list-tables-rtl.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

wp-admin/css/list-tables.css

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1452,6 +1452,14 @@ ul.cat-checklist input[name="post_category[]"]:indeterminate::before {
14521452
content: "\f147" / '';
14531453
}
14541454

1455+
.plugin-card .updated-message:before,
1456+
.plugin-card .updating-message:before {
1457+
line-height: 1;
1458+
position: relative;
1459+
top: -2px;
1460+
vertical-align: middle;
1461+
}
1462+
14551463
.plugin-install-php #the-list {
14561464
display: flex;
14571465
flex-wrap: wrap;

wp-admin/css/list-tables.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

wp-admin/css/themes-rtl.css

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,8 @@ body.js .theme-browser.search-loading {
115115
}
116116

117117
/* Use compact size for space-constrained theme cards */
118+
.theme-browser .theme .theme-actions .button.updated-message,
119+
.theme-browser .theme .theme-actions .button.updating-message,
118120
.theme-browser .theme .theme-actions .button {
119121
float: none;
120122
margin-right: 3px;
@@ -123,6 +125,14 @@ body.js .theme-browser.search-loading {
123125
padding: 0 12px;
124126
}
125127

128+
.theme-browser .theme .theme-actions .button.updated-message::before,
129+
.theme-browser .theme .theme-actions .button.updating-message::before {
130+
line-height: 1;
131+
vertical-align: text-bottom;
132+
position: relative;
133+
top: 2px;
134+
}
135+
126136
/* Secondary buttons need white background for visibility on semi-transparent overlay */
127137
.theme-browser .theme .theme-actions .button:not(.button-primary) {
128138
background: #fff;

wp-admin/css/themes-rtl.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

wp-admin/css/themes.css

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,8 @@ body.js .theme-browser.search-loading {
114114
}
115115

116116
/* Use compact size for space-constrained theme cards */
117+
.theme-browser .theme .theme-actions .button.updated-message,
118+
.theme-browser .theme .theme-actions .button.updating-message,
117119
.theme-browser .theme .theme-actions .button {
118120
float: none;
119121
margin-left: 3px;
@@ -122,6 +124,14 @@ body.js .theme-browser.search-loading {
122124
padding: 0 12px;
123125
}
124126

127+
.theme-browser .theme .theme-actions .button.updated-message::before,
128+
.theme-browser .theme .theme-actions .button.updating-message::before {
129+
line-height: 1;
130+
vertical-align: text-bottom;
131+
position: relative;
132+
top: 2px;
133+
}
134+
125135
/* Secondary buttons need white background for visibility on semi-transparent overlay */
126136
.theme-browser .theme .theme-actions .button:not(.button-primary) {
127137
background: #fff;

wp-admin/css/themes.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

wp-includes/version.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
*
1717
* @global string $wp_version
1818
*/
19-
$wp_version = '7.0-beta1-61740';
19+
$wp_version = '7.0-beta1-61741';
2020

2121
/**
2222
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.

0 commit comments

Comments
 (0)