Skip to content

Commit f272ae1

Browse files
committed
patch 8.2.2442: automatic GUI selection does not check for GTK 3
Problem: Automatic GUI selection does not check for GTK 3. Solution: Make SKIP_GTK3 empty for automatic GUI support. Set SKIP_GTK3 to YES when checking for GTK2.
1 parent c03f5c6 commit f272ae1

3 files changed

Lines changed: 22 additions & 0 deletions

File tree

src/auto/configure

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9262,6 +9262,7 @@ $as_echo "no GUI support" >&6; } ;;
92629262
$as_echo "yes/auto - automatic GUI support" >&6; }
92639263
gui_auto=yes
92649264
SKIP_GTK2=
9265+
SKIP_GTK3=
92659266
SKIP_GNOME=
92669267
SKIP_MOTIF=
92679268
SKIP_ATHENA=
@@ -9523,6 +9524,8 @@ $as_echo "gtk test disabled" >&6; }
95239524
fi
95249525

95259526
if test "x$PKG_CONFIG" != "xno"; then
9527+
save_skip_gtk3=$SKIP_GTK3
9528+
SKIP_GTK3=YES
95269529

95279530
if test "X$GTK_CONFIG" != "Xno" -o "X$PKG_CONFIG" != "Xno"; then
95289531
{
@@ -9666,6 +9669,8 @@ $as_echo "no" >&6; }
96669669
SKIP_MOTIF=YES
96679670
GUITYPE=GTK
96689671

9672+
else
9673+
SKIP_GTK3=$save_skip_gtk3
96699674
fi
96709675
fi
96719676
if test "x$GUITYPE" = "xGTK"; then
@@ -9778,6 +9783,8 @@ $as_echo "gtk test disabled" >&6; }
97789783
fi
97799784

97809785
if test "x$PKG_CONFIG" != "xno"; then
9786+
save_skip_gtk2=$SKIP_GTK2
9787+
SKIP_GTK2=YES
97819788

97829789
if test "X$GTK_CONFIG" != "Xno" -o "X$PKG_CONFIG" != "Xno"; then
97839790
{
@@ -9924,6 +9931,8 @@ $as_echo "no" >&6; }
99249931

99259932
$as_echo "#define USE_GTK3 1" >>confdefs.h
99269933

9934+
else
9935+
SKIP_GTK2=$save_skip_gtk2
99279936
fi
99289937
fi
99299938
fi

src/configure.ac

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2448,6 +2448,7 @@ else
24482448
yes|""|auto) AC_MSG_RESULT(yes/auto - automatic GUI support)
24492449
gui_auto=yes
24502450
SKIP_GTK2=
2451+
SKIP_GTK3=
24512452
SKIP_GNOME=
24522453
SKIP_MOTIF=
24532454
SKIP_ATHENA=
@@ -2759,6 +2760,10 @@ if test -z "$SKIP_GTK2"; then
27592760
if test "x$PKG_CONFIG" != "xno"; then
27602761
dnl First try finding version 2.2.0 or later. The 2.0.x series has
27612762
dnl problems (bold fonts, --remote doesn't work).
2763+
dnl Disable checking for GTK3 here, otherwise it's found when GTK2 is not
2764+
dnl found.
2765+
save_skip_gtk3=$SKIP_GTK3
2766+
SKIP_GTK3=YES
27622767
AM_PATH_GTK(2.2.0,
27632768
[GUI_LIB_LOC="$GTK_LIBDIR"
27642769
GTK_LIBNAME="$GTK_LIBS"
@@ -2770,6 +2775,8 @@ if test -z "$SKIP_GTK2"; then
27702775
SKIP_MOTIF=YES
27712776
GUITYPE=GTK
27722777
AC_SUBST(GTK_LIBNAME)
2778+
else
2779+
SKIP_GTK3=$save_skip_gtk3
27732780
fi
27742781
fi
27752782
if test "x$GUITYPE" = "xGTK"; then
@@ -2805,6 +2812,8 @@ if test -z "$SKIP_GTK3"; then
28052812
fi
28062813

28072814
if test "x$PKG_CONFIG" != "xno"; then
2815+
save_skip_gtk2=$SKIP_GTK2
2816+
SKIP_GTK2=YES
28082817
AM_PATH_GTK(3.0.0,
28092818
[GUI_LIB_LOC="$GTK_LIBDIR"
28102819
GTK_LIBNAME="$GTK_LIBS"
@@ -2818,6 +2827,8 @@ if test -z "$SKIP_GTK3"; then
28182827
GUITYPE=GTK
28192828
AC_SUBST(GTK_LIBNAME)
28202829
AC_DEFINE(USE_GTK3)
2830+
else
2831+
SKIP_GTK2=$save_skip_gtk2
28212832
fi
28222833
fi
28232834
fi

src/version.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -750,6 +750,8 @@ static char *(features[]) =
750750

751751
static int included_patches[] =
752752
{ /* Add new patch number below this line */
753+
/**/
754+
2442,
753755
/**/
754756
2441,
755757
/**/

0 commit comments

Comments
 (0)