Skip to content

Commit ec0e07a

Browse files
committed
patch 8.0.0986: terminal feature always requires multi-byte feature
Problem: Terminal feature always requires multi-byte feature. Solution: Remove #ifdef FEAT_MBYTE, disable terminal without multi-byte.
1 parent 6d0826d commit ec0e07a

3 files changed

Lines changed: 7 additions & 10 deletions

File tree

src/feature.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1269,8 +1269,10 @@
12691269

12701270
/*
12711271
* +terminal ":terminal" command. Runs a terminal in a window.
1272+
* requires +channel and +multibyte
12721273
*/
1273-
#if !defined(FEAT_JOB_CHANNEL) && defined(FEAT_TERMINAL)
1274+
#if defined(FEAT_TERMINAL) && \
1275+
!(defined(FEAT_JOB_CHANNEL) && defined(FEAT_MBYTE))
12741276
# undef FEAT_TERMINAL
12751277
#endif
12761278
#if defined(FEAT_TERMINAL) && !defined(CURSOR_SHAPE)

src/terminal.c

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@
6363
* mouse in the Terminal window for copy/paste.
6464
* - when 'encoding' is not utf-8, or the job is using another encoding, setup
6565
* conversions.
66-
* - update ":help function-list" for terminal functions.
6766
* - In the GUI use a terminal emulator for :!cmd.
6867
* - Copy text in the vterm to the Vim buffer once in a while, so that
6968
* completion works.
@@ -2103,14 +2102,11 @@ term_update_window(win_T *wp)
21032102
if (c == NUL)
21042103
{
21052104
ScreenLines[off] = ' ';
2106-
#if defined(FEAT_MBYTE)
21072105
if (enc_utf8)
21082106
ScreenLinesUC[off] = NUL;
2109-
#endif
21102107
}
21112108
else
21122109
{
2113-
#if defined(FEAT_MBYTE)
21142110
if (enc_utf8)
21152111
{
21162112
if (c >= 0x80)
@@ -2124,7 +2120,7 @@ term_update_window(win_T *wp)
21242120
ScreenLinesUC[off] = NUL;
21252121
}
21262122
}
2127-
# ifdef WIN3264
2123+
#ifdef WIN3264
21282124
else if (has_mbyte && c >= 0x80)
21292125
{
21302126
char_u mb[MB_MAXBYTES+1];
@@ -2140,9 +2136,8 @@ term_update_window(win_T *wp)
21402136
else
21412137
ScreenLines[off] = c;
21422138
}
2143-
# endif
2144-
else
21452139
#endif
2140+
else
21462141
ScreenLines[off] = c;
21472142
}
21482143
ScreenAttrs[off] = cell2attr(cell.attrs, cell.fg, cell.bg);
@@ -2151,11 +2146,9 @@ term_update_window(win_T *wp)
21512146
++off;
21522147
if (cell.width == 2)
21532148
{
2154-
#if defined(FEAT_MBYTE)
21552149
if (enc_utf8)
21562150
ScreenLinesUC[off] = NUL;
21572151
else if (!has_mbyte)
2158-
#endif
21592152
ScreenLines[off] = NUL;
21602153
++pos.col;
21612154
++off;

src/version.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -769,6 +769,8 @@ static char *(features[]) =
769769

770770
static int included_patches[] =
771771
{ /* Add new patch number below this line */
772+
/**/
773+
986,
772774
/**/
773775
985,
774776
/**/

0 commit comments

Comments
 (0)