Skip to content

Commit e3e82fb

Browse files
committed
Fix docs and preferences to indicate non-CoreText renderer is deprecated
Now that CoreText scrolling performance is fixed with the stateful renderer we should eventually stop supporting the legacy NSTextView renderer which doesn't renderer properly and cannot do proper fixed-width column rendering that Vim uses. Mark it as deprecated for now but it will be removed in the future.
1 parent 1961d05 commit e3e82fb

4 files changed

Lines changed: 4 additions & 7 deletions

File tree

runtime/doc/gui_mac.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,7 @@ KEY VALUE ~
257257
*MMLoginShellArgument* login shell parameter [string]
258258
*MMLoginShellCommand* which shell to use to launch Vim [string]
259259
*MMNoFontSubstitution* disable automatic font substitution [bool]
260+
(Deprecated: Non-CoreText renderer only)
260261
*MMNoTitleBarWindow* hide title bar [bool]
261262
*MMTitlebarAppearsTransparent* enable a transparent titlebar [bool]
262263
*MMAppearanceModeSelection* dark mode selection (|macvim-dark-mode|)[bool]
@@ -793,9 +794,6 @@ if you would like to see certain messages localized.
793794
This list is by no means exhaustive, it only enumerates some of the more
794795
prominent bugs/missing features.
795796

796-
- Under macOS Mojave (10.14), the default renderer (Core Text renderer) has
797-
some performance issues and scrolling is not as smooth as previous macOS
798-
versions (10.13 or below).
799797
- Sound. MacVim does not currently support |+sound| yet.
800798
- |modifyOtherKeys| support. This feature allows for more granular key
801799
mapping (e.g. differentiating <C-I> and <Tab>) and isn't supported by the

src/MacVim/Base.lproj/Preferences.xib

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -367,9 +367,8 @@
367367
<textField verticalHuggingPriority="750" horizontalCompressionResistancePriority="250" fixedFrame="YES" id="815">
368368
<rect key="frame" x="17" y="252" width="449" height="28"/>
369369
<autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
370-
<textFieldCell key="cell" controlSize="small" sendsActionOnEndEditing="YES" id="991">
370+
<textFieldCell key="cell" controlSize="small" sendsActionOnEndEditing="YES" title="(Deprecated) Deselect this option to use the legacy renderer, which is unsupported and will be removed in a future version." id="991">
371371
<font key="font" metaFont="smallSystem"/>
372-
<string key="title">Selecting this option will increase rendering performance but double-tapping with three fingers to look up words will no longer work.</string>
373372
<color key="textColor" white="0.5" alpha="1" colorSpace="calibratedWhite"/>
374373
<color key="backgroundColor" name="controlColor" catalog="System" colorSpace="catalog"/>
375374
</textFieldCell>

src/MacVim/MacVim.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ extern NSString *MMShareFindPboardKey;
348348

349349
extern NSString *MMAutosaveRowsKey;
350350
extern NSString *MMAutosaveColumnsKey;
351-
extern NSString *MMRendererKey;
351+
extern NSString *MMRendererKey; // Deprecated: Non-CoreText renderer
352352

353353
enum {
354354
MMRendererDefault = 0,

src/MacVim/Miscellaneous.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ extern NSString *MMBaselineOffsetKey;
3232
extern NSString *MMTranslateCtrlClickKey;
3333
extern NSString *MMTopLeftPointKey;
3434
extern NSString *MMOpenInCurrentWindowKey;
35-
extern NSString *MMNoFontSubstitutionKey;
35+
extern NSString *MMNoFontSubstitutionKey; // Deprecated: Non-CoreText renderer
3636
extern NSString *MMAppearanceModeSelectionKey;
3737
extern NSString *MMNoTitleBarWindowKey;
3838
extern NSString *MMTitlebarAppearsTransparentKey;

0 commit comments

Comments
 (0)