Skip to content

Commit dc1c981

Browse files
committed
patch 8.0.1227: undefined left shift in readfile()
Problem: Undefined left shift in readfile(). (Brian 'geeknik' Carpenter) Solution: Add cast to unsigned. (Dominique Pelle, closes #2253)
1 parent 2a45d64 commit dc1c981

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

src/fileio.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1956,17 +1956,17 @@ readfile(
19561956
{
19571957
if (fio_flags & FIO_ENDIAN_L)
19581958
{
1959-
u8c = (*--p << 24);
1960-
u8c += (*--p << 16);
1961-
u8c += (*--p << 8);
1959+
u8c = (unsigned)*--p << 24;
1960+
u8c += (unsigned)*--p << 16;
1961+
u8c += (unsigned)*--p << 8;
19621962
u8c += *--p;
19631963
}
19641964
else /* big endian */
19651965
{
19661966
u8c = *--p;
1967-
u8c += (*--p << 8);
1968-
u8c += (*--p << 16);
1969-
u8c += (*--p << 24);
1967+
u8c += (unsigned)*--p << 8;
1968+
u8c += (unsigned)*--p << 16;
1969+
u8c += (unsigned)*--p << 24;
19701970
}
19711971
}
19721972
else /* UTF-8 */

src/version.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -761,6 +761,8 @@ static char *(features[]) =
761761

762762
static int included_patches[] =
763763
{ /* Add new patch number below this line */
764+
/**/
765+
1227,
764766
/**/
765767
1226,
766768
/**/

0 commit comments

Comments
 (0)