Skip to content

Commit c9fb77c

Browse files
committed
patch 7.4.2188
Problem: Completion does not work properly with some plugins. Solution: Revert the part related to typing CTRL-E. (closes #972)
1 parent 7547a78 commit c9fb77c

3 files changed

Lines changed: 9 additions & 6 deletions

File tree

src/edit.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3893,7 +3893,7 @@ ins_compl_prep(int c)
38933893

38943894
/* CTRL-E means completion is Ended, go back to the typed text.
38953895
* but only do this, if the Popup is still visible */
3896-
if (c == Ctrl_E && pum_visible())
3896+
if (c == Ctrl_E)
38973897
{
38983898
ins_compl_delete();
38993899
if (compl_leader != NULL)

src/testdir/test_popup.vim

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -170,11 +170,12 @@ func! Test_popup_complete()
170170

171171
" Insert match immediately, if there is only one match
172172
" <c-e> Should select a character from the line below
173-
call append(1, ["December2015"])
174-
:1
175-
call feedkeys("aD\<f5>\<C-E>\<C-E>\<C-E>\<C-E>\<enter>\<esc>", 'tx')
176-
call assert_equal(["December2015", "", "December2015"], getline(1,3))
177-
%d
173+
" TODO: test disabled because the code change has been reverted.
174+
" call append(1, ["December2015"])
175+
" :1
176+
" call feedkeys("aD\<f5>\<C-E>\<C-E>\<C-E>\<C-E>\<enter>\<esc>", 'tx')
177+
" call assert_equal(["December2015", "", "December2015"], getline(1,3))
178+
" %d
178179

179180
" use menuone for 'completeopt'
180181
" Since for the first <c-y> the menu is still shown, will only select

src/version.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -763,6 +763,8 @@ static char *(features[]) =
763763

764764
static int included_patches[] =
765765
{ /* Add new patch number below this line */
766+
/**/
767+
2188,
766768
/**/
767769
2187,
768770
/**/

0 commit comments

Comments
 (0)