Merge remote-tracking branch 'vim/master'

ichizok · ichizok · commit af0da56f3ce5 · 2021-02-08T15:18:19.000+09:00
diff --git a/src/buffer.c b/src/buffer.c
@@ -595,6 +595,7 @@ close_buffer(
     if (buf->b_nwindows == 1)
     {
 	++buf->b_locked;
+	++buf->b_locked_split;
 	if (apply_autocmds(EVENT_BUFWINLEAVE, buf->b_fname, buf->b_fname,
 								  FALSE, buf)
 		&& !bufref_valid(&bufref))
@@ -605,6 +606,7 @@ close_buffer(
 	    return FALSE;
 	}
 	--buf->b_locked;
+	--buf->b_locked_split;
 	if (abort_if_last && one_window())
 	    // Autocommands made this the only window.
 	    goto aucmd_abort;
@@ -614,12 +616,14 @@ close_buffer(
 	if (!unload_buf)
 	{
 	    ++buf->b_locked;
+	    ++buf->b_locked_split;
 	    if (apply_autocmds(EVENT_BUFHIDDEN, buf->b_fname, buf->b_fname,
 								  FALSE, buf)
 		    && !bufref_valid(&bufref))
 		// Autocommands deleted the buffer.
 		goto aucmd_abort;
 	    --buf->b_locked;
+	    --buf->b_locked_split;
 	    if (abort_if_last && one_window())
 		// Autocommands made this the only window.
 		goto aucmd_abort;
@@ -804,6 +808,7 @@ buf_freeall(buf_T *buf, int flags)
 
     // Make sure the buffer isn't closed by autocommands.
     ++buf->b_locked;
+    ++buf->b_locked_split;
     set_bufref(&bufref, buf);
     if (buf->b_ml.ml_mfp != NULL)
     {
@@ -830,6 +835,7 @@ buf_freeall(buf_T *buf, int flags)
 	    return;
     }
     --buf->b_locked;
+    --buf->b_locked_split;
 
     // If the buffer was in curwin and the window has changed, go back to that
     // window, if it still exists.  This avoids that ":edit x" triggering a
@@ -1722,8 +1728,8 @@ set_curbuf(buf_T *buf, int action)
     set_bufref(&prevbufref, prevbuf);
     set_bufref(&newbufref, buf);
 
-    // Autocommands may delete the current buffer and/or the buffer we want to go
-    // to.  In those cases don't close the buffer.
+    // Autocommands may delete the current buffer and/or the buffer we want to
+    // go to.  In those cases don't close the buffer.
     if (!apply_autocmds(EVENT_BUFLEAVE, NULL, NULL, FALSE, curbuf)
 	    || (bufref_valid(&prevbufref)
 		&& bufref_valid(&newbufref)
diff --git a/src/dict.c b/src/dict.c
@@ -945,7 +945,7 @@ eval_dict(char_u **arg, typval_T *rettv, evalarg_T *evalarg, int literal)
 	if (**arg != ':')
 	{
 	    if (*skipwhite(*arg) == ':')
-		semsg(_(e_no_white_space_allowed_before_str), ":");
+		semsg(_(e_no_white_space_allowed_before_str_str), ":", *arg);
 	    else
 		semsg(_(e_missing_dict_colon), *arg);
 	    clear_tv(&tvkey);
@@ -970,7 +970,7 @@ eval_dict(char_u **arg, typval_T *rettv, evalarg_T *evalarg, int literal)
 	}
 	if (vim9script && (*arg)[1] != NUL && !VIM_ISWHITE((*arg)[1]))
 	{
-	    semsg(_(e_white_space_required_after_str), ":");
+	    semsg(_(e_white_space_required_after_str_str), ":", *arg);
 	    clear_tv(&tvkey);
 	    goto failret;
 	}
@@ -1012,7 +1012,7 @@ eval_dict(char_u **arg, typval_T *rettv, evalarg_T *evalarg, int literal)
 	{
 	    if (vim9script && (*arg)[1] != NUL && !VIM_ISWHITE((*arg)[1]))
 	    {
-		semsg(_(e_white_space_required_after_str), ",");
+		semsg(_(e_white_space_required_after_str_str), ",", *arg);
 		goto failret;
 	    }
 	    *arg = skipwhite(*arg + 1);
@@ -1025,7 +1025,7 @@ eval_dict(char_u **arg, typval_T *rettv, evalarg_T *evalarg, int literal)
 	if (!had_comma)
 	{
 	    if (**arg == ',')
-		semsg(_(e_no_white_space_allowed_before_str), ",");
+		semsg(_(e_no_white_space_allowed_before_str_str), ",", *arg);
 	    else
 		semsg(_(e_missing_dict_comma), *arg);
 	    goto failret;
diff --git a/src/errors.h b/src/errors.h
@@ -173,10 +173,10 @@ EXTERN char e_cannot_declare_a_register_str[]
 	INIT(= N_("E1066: Cannot declare a register: %s"));
 EXTERN char e_separator_mismatch_str[]
 	INIT(= N_("E1067: Separator mismatch: %s"));
-EXTERN char e_no_white_space_allowed_before_str[]
-	INIT(= N_("E1068: No white space allowed before '%s'"));
-EXTERN char e_white_space_required_after_str[]
-	INIT(= N_("E1069: White space required after '%s'"));
+EXTERN char e_no_white_space_allowed_before_str_str[]
+	INIT(= N_("E1068: No white space allowed before '%s': %s"));
+EXTERN char e_white_space_required_after_str_str[]
+	INIT(= N_("E1069: White space required after '%s': %s"));
 EXTERN char e_missing_from[]
 	INIT(= N_("E1070: Missing \"from\""));
 EXTERN char e_invalid_string_after_from[]
@@ -353,3 +353,7 @@ EXTERN char e_missing_return_type[]
 	INIT(= N_("E1157: Missing return type"));
 EXTERN char e_cannot_use_flatten_in_vim9_script[]
 	INIT(= N_("E1158: Cannot use flatten() in Vim9 script"));
+EXTERN char e_cannot_split_window_when_closing_buffer[]
+	INIT(= N_("E1159: Cannot split a window when closing the buffer"));
+EXTERN char e_cannot_use_default_for_variable_arguments[]
+	INIT(= N_("E1160: Cannot use a default for variable arguments"));
diff --git a/src/ex_docmd.c b/src/ex_docmd.c
@@ -5218,8 +5218,7 @@ ends_excmd2(char_u *cmd_start UNUSED, char_u *cmd)
 	return TRUE;
 #ifdef FEAT_EVAL
     if (in_vim9script())
-	return c == '#' && cmd[1] != '{'
-				 && (cmd == cmd_start || VIM_ISWHITE(cmd[-1]));
+	return c == '#' && (cmd == cmd_start || VIM_ISWHITE(cmd[-1]));
 #endif
     return c == '"';
 }
diff --git a/src/filepath.c b/src/filepath.c
@@ -3360,7 +3360,10 @@ dos_expandpath(
 	if (p == NULL)
 	    break;  // out of memory
 
-	if (*wfb.cAlternateFileName == NUL)
+	// Do not use the alternate filename when the file name ends in '~',
+	// because it picks up backup files: short name for "foo.vim~" is
+	// "foo~1.vim", which matches "*.vim".
+	if (*wfb.cAlternateFileName == NUL || p[STRLEN(p) - 1] == '~')
 	    p_alt = NULL;
 	else
 	    p_alt = utf16_to_enc(wfb.cAlternateFileName, NULL);
diff --git a/src/list.c b/src/list.c
@@ -1311,7 +1311,7 @@ eval_list(char_u **arg, typval_T *rettv, evalarg_T *evalarg, int do_error)
 	{
 	    if (vim9script && !IS_WHITE_OR_NUL((*arg)[1]) && (*arg)[1] != ']')
 	    {
-		semsg(_(e_white_space_required_after_str), ",");
+		semsg(_(e_white_space_required_after_str_str), ",", *arg);
 		goto failret;
 	    }
 	    *arg = skipwhite(*arg + 1);
@@ -1328,7 +1328,8 @@ eval_list(char_u **arg, typval_T *rettv, evalarg_T *evalarg, int do_error)
 	    if (do_error)
 	    {
 		if (**arg == ',')
-		    semsg(_(e_no_white_space_allowed_before_str), ",");
+		    semsg(_(e_no_white_space_allowed_before_str_str),
+								    ",", *arg);
 		else
 		    semsg(_("E696: Missing comma in List: %s"), *arg);
 	    }
diff --git a/src/popupwin.c b/src/popupwin.c
@@ -1941,7 +1941,7 @@ popup_create(typval_T *argvars, typval_T *rettv, create_type_T type)
 	buf->b_p_ul = -1;	// no undo
 	buf->b_p_swf = FALSE;   // no swap file
 	buf->b_p_bl = FALSE;    // unlisted buffer
-	buf->b_locked = TRUE;
+	buf->b_locked = TRUE;	// prevent deleting the buffer
 
 	// Avoid that 'buftype' is reset when this buffer is entered.
 	buf->b_p_initialized = TRUE;
diff --git a/src/scriptfile.c b/src/scriptfile.c
@@ -1319,6 +1319,9 @@ do_source(
 	    }
 	// imports can be redefined once
 	mark_imports_for_reload(sid);
+
+	// reset version, "vim9script" may have been added or removed.
+	si->sn_version = 1;
     }
     else
     {
@@ -1457,7 +1460,7 @@ do_source(
     if (si->sn_save_cpo != NULL)
     {
 	set_option_value((char_u *)"cpo", 0L, si->sn_save_cpo, 0);
-	CLEAR_POINTER(si->sn_save_cpo);
+	VIM_CLEAR(si->sn_save_cpo);
     }
 
     restore_funccal();
diff --git a/src/structs.h b/src/structs.h
@@ -2636,6 +2636,8 @@ struct file_buffer
     int		b_flags;	// various BF_ flags
     int		b_locked;	// Buffer is being closed or referenced, don't
 				// let autocommands wipe it out.
+    int		b_locked_split;	// Buffer is being closed, don't allow opening
+				// a new window with it.
 
     /*
      * b_ffname has the full path of the file (NULL for no name).
diff --git a/src/testdir/test_autocmd.vim b/src/testdir/test_autocmd.vim
@@ -2761,15 +2761,15 @@ endfunc
 
 " Fuzzer found some strange combination that caused a crash.
 func Test_autocmd_normal_mess()
-  " TODO: why does this hang on Windows?
+  " For unknown reason this hangs on MS-Windows
   CheckNotMSWindows
 
   augroup aucmd_normal_test
     au BufLeave,BufWinLeave,BufHidden,BufUnload,BufDelete,BufWipeout * norm 7q/qc
   augroup END
-  o4
+  call assert_fails('o4', 'E1159')
   silent! H
-  e xx
+  call assert_fails('e xx', 'E1159')
   normal G
 
   augroup aucmd_normal_test
@@ -2778,6 +2778,9 @@ func Test_autocmd_normal_mess()
 endfunc
 
 func Test_autocmd_closing_cmdwin()
+  " For unknown reason this hangs on MS-Windows
+  CheckNotMSWindows
+
   au BufWinLeave * nested q
   call assert_fails("norm 7q?\n", 'E855:')
 
@@ -2791,8 +2794,8 @@ func Test_autocmd_vimgrep()
     au QuickfixCmdPre,BufNew,BufDelete,BufReadCmd * sb
     au QuickfixCmdPre,BufNew,BufDelete,BufReadCmd * q9 
   augroup END
-  " TODO: if this is executed directly valgrind reports errors
-  call assert_fails('lv?a?', 'E926:')
+  %bwipe!
+  call assert_fails('lv ?a? foo', 'E926:')
 
   augroup aucmd_vimgrep
     au!
diff --git a/src/testdir/test_bufline.vim b/src/testdir/test_bufline.vim
@@ -40,11 +40,13 @@ func Test_setbufline_getbufline()
   call assert_equal([], getbufline(b, 6))
   call assert_equal([], getbufline(b, 2, 1))
 
-  call setbufline(b, 2, [function('eval'), #{key: 123}, test_null_job()])
-  call assert_equal(["function('eval')",
-                  \ "{'key': 123}",
-                  \ "no process"],
-                  \ getbufline(b, 2, 4))
+  if has('job')
+    call setbufline(b, 2, [function('eval'), #{key: 123}, test_null_job()])
+    call assert_equal(["function('eval')",
+                    \ "{'key': 123}",
+                    \ "no process"],
+                    \ getbufline(b, 2, 4))
+  endif
   exe "bwipe! " . b
 endfunc
 
diff --git a/src/testdir/test_vim9_builtin.vim b/src/testdir/test_vim9_builtin.vim
@@ -824,11 +824,13 @@ def Test_set_get_bufline()
       assert_equal([], getbufline(b, 6))
       assert_equal([], getbufline(b, 2, 1))
 
-      setbufline(b, 2, [function('eval'), {key: 123}, test_null_job()])
-      assert_equal(["function('eval')",
-                      "{'key': 123}",
-                      "no process"],
-                      getbufline(b, 2, 4))
+      if has('job')
+        setbufline(b, 2, [function('eval'), {key: 123}, test_null_job()])
+        assert_equal(["function('eval')",
+                        "{'key': 123}",
+                        "no process"],
+                        getbufline(b, 2, 4))
+      endif
 
       exe 'bwipe! ' .. b
   END
diff --git a/src/testdir/test_vim9_func.vim b/src/testdir/test_vim9_func.vim
@@ -781,6 +781,16 @@ def Test_call_def_varargs()
       Func(1, 'a')
   END
   CheckScriptFailure(lines, 'E1013: Argument 1: type mismatch')
+
+  lines =<< trim END
+      vim9script
+      def Func(  # some comment
+                ...l = []
+                )
+        echo l
+      enddef
+  END
+  CheckScriptFailure(lines, 'E1160:')
 enddef
 
 let s:value = ''
diff --git a/src/testdir/test_vim9_script.vim b/src/testdir/test_vim9_script.vim
@@ -1743,6 +1743,21 @@ def Test_if_elseif_else_fails()
   CheckDefFailure(['endif'], 'E580:')
   CheckDefFailure(['if g:abool', 'elseif xxx'], 'E1001:')
   CheckDefFailure(['if true', 'echo 1'], 'E171:')
+
+  var lines =<< trim END
+      var s = ''
+      if s = ''
+      endif
+  END
+  CheckDefFailure(lines, 'E488:')
+
+  lines =<< trim END
+      var s = ''
+      if s == ''
+      elseif s = ''
+      endif
+  END
+  CheckDefFailure(lines, 'E488:')
 enddef
 
 let g:bool_true = v:true
@@ -2190,6 +2205,10 @@ def Test_while_loop()
     result ..= cnt .. '_'
   endwhile
   assert_equal('1_3_', result)
+
+  var s = ''
+  while s == 'x' #{comment}
+  endwhile
 enddef
 
 def Test_while_loop_fails()
@@ -2200,6 +2219,13 @@ def Test_while_loop_fails()
   CheckDefFailure(['break'], 'E587:')
   CheckDefFailure(['if true', 'break'], 'E587:')
   CheckDefFailure(['while 1', 'echo 3'], 'E170:')
+
+  var lines =<< trim END
+      var s = ''
+      while s = ''
+      endwhile
+  END
+  CheckDefFailure(lines, 'E488:')
 enddef
 
 def Test_interrupt_loop()
@@ -3129,6 +3155,19 @@ def Test_restoring_cpo()
   delete('Xsourced')
   delete('Xclose')
   delete('Xdone')
+
+  writefile(['vim9script'], 'XanotherScript')
+  set cpo=aABceFsMny>
+  edit XanotherScript
+  so %
+  assert_equal('aABceFsMny>', &cpo)
+  :1del
+  w
+  so %
+  assert_equal('aABceFsMny>', &cpo)
+
+  delete('XanotherScript')
+  set cpo&vim
 enddef
 
 
diff --git a/src/userfunc.c b/src/userfunc.c
diff --git a/src/version.c b/src/version.c
diff --git a/src/vim9compile.c b/src/vim9compile.c
diff --git a/src/vim9script.c b/src/vim9script.c
diff --git a/src/vim9type.c b/src/vim9type.c
diff --git a/src/window.c b/src/window.c

Original file line number	Diff line number	Diff line change
`@@ -945,7 +945,7 @@ eval_dict(char_u *arg, typval_T rettv, evalarg_T *evalarg, int literal)`
`945`	`945`	`if (**arg != ':')`
`946`	`946`	`{`
`947`	`947`	`if (skipwhite(arg) == ':')`
`948`		`- semsg(_(e_no_white_space_allowed_before_str), ":");`
	`948`	`+ semsg(_(e_no_white_space_allowed_before_str_str), ":", *arg);`
`949`	`949`	`else`
`950`	`950`	`semsg(_(e_missing_dict_colon), *arg);`
`951`	`951`	`clear_tv(&tvkey);`
`@@ -970,7 +970,7 @@ eval_dict(char_u *arg, typval_T rettv, evalarg_T *evalarg, int literal)`
`970`	`970`	`}`
`971`	`971`	`if (vim9script && (arg)[1] != NUL && !VIM_ISWHITE((arg)[1]))`
`972`	`972`	`{`
`973`		`- semsg(_(e_white_space_required_after_str), ":");`
	`973`	`+ semsg(_(e_white_space_required_after_str_str), ":", *arg);`
`974`	`974`	`clear_tv(&tvkey);`
`975`	`975`	`goto failret;`
`976`	`976`	`}`
`@@ -1012,7 +1012,7 @@ eval_dict(char_u *arg, typval_T rettv, evalarg_T *evalarg, int literal)`
`1012`	`1012`	`{`
`1013`	`1013`	`if (vim9script && (arg)[1] != NUL && !VIM_ISWHITE((arg)[1]))`
`1014`	`1014`	`{`
`1015`		`- semsg(_(e_white_space_required_after_str), ",");`
	`1015`	`+ semsg(_(e_white_space_required_after_str_str), ",", *arg);`
`1016`	`1016`	`goto failret;`
`1017`	`1017`	`}`
`1018`	`1018`	`arg = skipwhite(arg + 1);`
`@@ -1025,7 +1025,7 @@ eval_dict(char_u *arg, typval_T rettv, evalarg_T *evalarg, int literal)`
`1025`	`1025`	`if (!had_comma)`
`1026`	`1026`	`{`
`1027`	`1027`	`if (**arg == ',')`
`1028`		`- semsg(_(e_no_white_space_allowed_before_str), ",");`
	`1028`	`+ semsg(_(e_no_white_space_allowed_before_str_str), ",", *arg);`
`1029`	`1029`	`else`
`1030`	`1030`	`semsg(_(e_missing_dict_comma), *arg);`
`1031`	`1031`	`goto failret;`
Original file line number	Diff line number	Diff line change
`@@ -1311,7 +1311,7 @@ eval_list(char_u *arg, typval_T rettv, evalarg_T *evalarg, int do_error)`
`1311`	`1311`	`{`
`1312`	`1312`	`if (vim9script && !IS_WHITE_OR_NUL((arg)[1]) && (arg)[1] != ']')`
`1313`	`1313`	`{`
`1314`		`- semsg(_(e_white_space_required_after_str), ",");`
	`1314`	`+ semsg(_(e_white_space_required_after_str_str), ",", *arg);`
`1315`	`1315`	`goto failret;`
`1316`	`1316`	`}`
`1317`	`1317`	`arg = skipwhite(arg + 1);`
`@@ -1328,7 +1328,8 @@ eval_list(char_u *arg, typval_T rettv, evalarg_T *evalarg, int do_error)`
`1328`	`1328`	`if (do_error)`
`1329`	`1329`	`{`
`1330`	`1330`	`if (**arg == ',')`
`1331`		`- semsg(_(e_no_white_space_allowed_before_str), ",");`
	`1331`	`+ semsg(_(e_no_white_space_allowed_before_str_str),`
	`1332`	`+ ",", *arg);`
`1332`	`1333`	`else`
`1333`	`1334`	`semsg(_("E696: Missing comma in List: %s"), *arg);`
`1334`	`1335`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1319,6 +1319,9 @@ do_source(`
`1319`	`1319`	`}`
`1320`	`1320`	`// imports can be redefined once`
`1321`	`1321`	`mark_imports_for_reload(sid);`
	`1322`	`+`
	`1323`	`+ // reset version, "vim9script" may have been added or removed.`
	`1324`	`+ si->sn_version = 1;`
`1322`	`1325`	`}`
`1323`	`1326`	`else`
`1324`	`1327`	`{`
`@@ -1457,7 +1460,7 @@ do_source(`
`1457`	`1460`	`if (si->sn_save_cpo != NULL)`
`1458`	`1461`	`{`
`1459`	`1462`	`set_option_value((char_u *)"cpo", 0L, si->sn_save_cpo, 0);`
`1460`		`- CLEAR_POINTER(si->sn_save_cpo);`
	`1463`	`+ VIM_CLEAR(si->sn_save_cpo);`
`1461`	`1464`	`}`
`1462`	`1465`
`1463`	`1466`	`restore_funccal();`