Skip to content

Commit acc682b

Browse files
committed
patch 8.1.1496: popup window height is not recomputed
Problem: Popup window height is not recomputed. Solution: Recompute the height when needed.
1 parent 1748c7f commit acc682b

3 files changed

Lines changed: 6 additions & 3 deletions

File tree

src/popupwin.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -541,8 +541,7 @@ popup_adjust_position(win_T *wp)
541541
wp->w_wincol = wp->w_wantcol - (wp->w_width + extra_width);
542542
}
543543

544-
if (wp->w_height <= 1)
545-
wp->w_height = wp->w_buffer->b_ml.ml_line_count + wrapped;
544+
wp->w_height = wp->w_buffer->b_ml.ml_line_count + wrapped;
546545
if (wp->w_minheight > 0 && wp->w_height < wp->w_minheight)
547546
wp->w_height = wp->w_minheight;
548547
if (wp->w_maxheight > 0 && wp->w_height > wp->w_maxheight)
@@ -566,11 +565,13 @@ popup_adjust_position(win_T *wp)
566565
wp->w_popup_last_changedtick = CHANGEDTICK(wp->w_buffer);
567566

568567
// Need to update popup_mask if the position or size changed.
568+
// And redraw windows that were behind the popup.
569569
if (org_winrow != wp->w_winrow
570570
|| org_wincol != wp->w_wincol
571571
|| org_width != wp->w_width
572572
|| org_height != wp->w_height)
573573
{
574+
// TODO: redraw only windows that were below the popup.
574575
redraw_all_later(NOT_VALID);
575576
popup_mask_refresh = TRUE;
576577
}

src/testdir/dumps/Test_popupwin_06.dump

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
|~| @6|o+0#0000001#ffd7ff255|t|h|e|r| |t|a|b| @15| +0#4040ff13#ffffff0@41
55
|~| @6|a+0#0000001#ffd7ff255| |c+0#ff404010&|o|m@1|e|n|t| +0#0000001&|l|i|n|e| @10| +0#4040ff13#ffffff0@41
66
|~| @6|t+0#0000001#ffd7ff255|h|i|s| |l|i|n|e| |w|i|l@1| |n|o|t| |f|i|t| |h|e| +0#4040ff13#ffffff0@41
7-
|~| @73
7+
|~| @6|r+0#0000001#ffd7ff255|e| @22| +0#4040ff13#ffffff0@41
88
|~| @73
99
|~| @73
1010
|:+0#0000000&|r|e|d|r|a|w| @49|0|,|0|-|1| @8|A|l@1|

src/version.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -767,6 +767,8 @@ static char *(features[]) =
767767

768768
static int included_patches[] =
769769
{ /* Add new patch number below this line */
770+
/**/
771+
1496,
770772
/**/
771773
1495,
772774
/**/

0 commit comments

Comments
 (0)