Skip to content

Commit 96898d7

Browse files
committed
patch 9.2.0255: tests: Test_popup_opacity_vsplit() fails in a wide terminal
Problem: tests: Test_popup_opacity_vsplit() fails in a wide terminal (after v9.2.0230) Solution: Reduce terminal window size to 60, force termguicolors to make the opacity visible; enable termguicolors so that the opacity is visually apparent in the screen dump. related: #19824 Signed-off-by: Christian Brabandt <[email protected]>
1 parent 7cb43f2 commit 96898d7

4 files changed

Lines changed: 29 additions & 26 deletions

File tree

src/testdir/dumps/Test_popupwin_opacity_vsplit_1.dump

Lines changed: 12 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/testdir/dumps/Test_popupwin_opacity_vsplit_2.dump

Lines changed: 12 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/testdir/test_popupwin.vim

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5029,21 +5029,22 @@ func Test_popup_opacity_vsplit()
50295029
" Opacity popup spanning a vertical split should redraw both windows
50305030
" underneath, not just the left one (blend accumulation bug).
50315031
let lines =<< trim END
5032+
set termguicolors
50325033
call setline(1, repeat(['left window text here xxxx'], 10))
50335034
vnew
50345035
call setline(1, repeat(['right window text here xxxx'], 10))
50355036
wincmd h
50365037
hi PopupColor guibg=darkblue guifg=white
50375038
let g:pop_id = popup_create(['opacity over vsplit'], #{
5038-
\ line: 3, col: 30,
5039+
\ line: 3, col: 19,
50395040
\ minwidth: 25,
50405041
\ highlight: 'PopupColor',
50415042
\ opacity: 50,
50425043
\ zindex: 50,
50435044
\})
50445045
END
50455046
call writefile(lines, 'XtestPopupOpacityVsplit', 'D')
5046-
let buf = RunVimInTerminal('-S XtestPopupOpacityVsplit', #{rows: 12, cols: 80})
5047+
let buf = RunVimInTerminal('-S XtestPopupOpacityVsplit', #{rows: 12, cols: 60})
50475048
call VerifyScreenDump(buf, 'Test_popupwin_opacity_vsplit_1', {})
50485049

50495050
" Move cursor multiple times to trigger redraws; without the fix the

src/version.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -734,6 +734,8 @@ static char *(features[]) =
734734

735735
static int included_patches[] =
736736
{ /* Add new patch number below this line */
737+
/**/
738+
255,
737739
/**/
738740
254,
739741
/**/

0 commit comments

Comments
 (0)