patch 9.0.1260: Coverity warns for possible NULL pointer usage

brammool · brammool · commit 836137d89abf · 2023-01-29T14:11:24.000Z
Problem:    Coverity warns for possible NULL pointer usage.
Solution:   Change the condition.
diff --git a/src/version.c b/src/version.c
@@ -695,6 +695,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    1260,
 /**/
     1259,
 /**/
diff --git a/src/vim9instr.c b/src/vim9instr.c
@@ -1794,7 +1794,7 @@ generate_CALL(
 			  : ufunc->uf_def_status != UF_NOT_COMPILED
 					     ? ISN_DCALL : ISN_UCALL)) == NULL)
 	return FAIL;
-    if (isn->isn_type == ISN_METHODCALL)
+    if (cl != NULL /* isn->isn_type == ISN_METHODCALL */)
     {
 	isn->isn_arg.mfunc = ALLOC_ONE(cmfunc_T);
 	if (isn->isn_arg.mfunc == NULL)

Original file line number	Diff line number	Diff line change
`@@ -1794,7 +1794,7 @@ generate_CALL(`
`1794`	`1794`	`: ufunc->uf_def_status != UF_NOT_COMPILED`
`1795`	`1795`	`? ISN_DCALL : ISN_UCALL)) == NULL)`
`1796`	`1796`	`return FAIL;`
`1797`		`- if (isn->isn_type == ISN_METHODCALL)`
	`1797`	`+ if (cl != NULL /* isn->isn_type == ISN_METHODCALL */)`
`1798`	`1798`	`{`
`1799`	`1799`	`isn->isn_arg.mfunc = ALLOC_ONE(cmfunc_T);`
`1800`	`1800`	`if (isn->isn_arg.mfunc == NULL)`