Commit 7ec24fa
committed
Fix drag-and-drop with swap file enabled causing MacVim to freeze
MMBackend's `handleOpenWithArguments` previously set a "flushDisabled"
flag to disable all flushing during handling the files. This was unsafe,
because under the new code that handles editing immediately (instead of
building a deferred set of Ex commands) MacVim tries to immediately pop
up a dialog box but that message doesn't get properly flushed because
it's disabled. Just remove the setting of that disabled flag as it
doesn't seem like it's gaining anything.
If we want to have a way to disable flushing for performance reasons in
the future , we should make sure the "force" flag in flushQueue:
actually gets respected and used properly (only when we want to force
it). Right now the "force" flag isn't actually used.
Also, make sure the dialog handling code handles the "no GUI resize"
resize message (which gets set when we have `guioptions+=k`) as well and
don't drop the message. Otherwise if drag-and-drop opens a new tab
(since there are multiple files dropped) and the user has guioptions+=k,
it won't get redrawn properly because the
SetTextDimensionsNoResizeWindowMsgID message would get dropped. It's
unfortunate it's a hardcoded hack like this and this should be revisited
in the future.
Fix #9131 parent 0cbfb73 commit 7ec24fa
1 file changed
Lines changed: 7 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
636 | 636 | | |
637 | 637 | | |
638 | 638 | | |
639 | | - | |
640 | | - | |
641 | | - | |
642 | | - | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
643 | 645 | | |
644 | 646 | | |
645 | 647 | | |
| |||
1793 | 1795 | | |
1794 | 1796 | | |
1795 | 1797 | | |
1796 | | - | |
| 1798 | + | |
1797 | 1799 | | |
1798 | 1800 | | |
1799 | 1801 | | |
| |||
2716 | 2718 | | |
2717 | 2719 | | |
2718 | 2720 | | |
2719 | | - | |
2720 | | - | |
2721 | | - | |
2722 | | - | |
2723 | 2721 | | |
2724 | 2722 | | |
2725 | 2723 | | |
| |||
2959 | 2957 | | |
2960 | 2958 | | |
2961 | 2959 | | |
2962 | | - | |
2963 | | - | |
2964 | 2960 | | |
2965 | 2961 | | |
2966 | 2962 | | |
| |||
0 commit comments