Skip to content

Commit 4f97475

Browse files
committed
patch 8.1.0941: macros for MS-Windows are inconsistent
Problem: Macros for MS-Windows are inconsistent, using "32", "3264 and others. Solution: Use MSWIN for all MS-Windows builds. Use FEAT_GUI_MSWIN for the GUI build. (Hirohito Higashi, closes #3932)
1 parent 78d21da commit 4f97475

68 files changed

Lines changed: 537 additions & 539 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

src/GvimExt/gvimext.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
# define STRICT
3232
#endif
3333

34-
#define INC_OLE2 // WIN32, get ole2 from windows.h
34+
#define INC_OLE2 // MS-Windows, get ole2 from windows.h
3535

3636
/* Visual Studio 2005 has 'deprecated' many of the standard CRT functions */
3737
#if defined(_MSC_VER) && _MSC_VER >= 1400

src/Make_bc5.mak

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ DEFINES = $(DEFINES) -DFEAT_CSCOPE
405405
!endif
406406

407407
!if ("$(GUI)"=="yes")
408-
DEFINES = $(DEFINES) -DFEAT_GUI_W32 -DFEAT_CLIPBOARD
408+
DEFINES = $(DEFINES) -DFEAT_GUI -DFEAT_CLIPBOARD
409409
!if ("$(DEBUG)"=="yes")
410410
TARGET = gvimd.exe
411411
!else

src/Make_cyg_ming.mak

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,7 @@ endif # RUBY
491491

492492
# See feature.h for a list of options.
493493
# Any other defines can be included here.
494-
DEF_GUI=-DFEAT_GUI_W32 -DFEAT_CLIPBOARD
494+
DEF_GUI=-DFEAT_GUI -DFEAT_CLIPBOARD
495495
DEFINES=-DWIN32 -DWINVER=$(WINVER) -D_WIN32_WINNT=$(WINVER) \
496496
-DHAVE_PATHDEF -DFEAT_$(FEATURES) -DHAVE_STDINT_H
497497
ifeq ($(ARCH),x86-64)

src/Make_ivc.mak

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ LINK32_FLAGS= oldnames.lib kernel32.lib user32.lib gdi32.lib version.lib comdlg3
9292
# ADD LINK32 oldnames.lib kernel32.lib user32.lib gdi32.lib version.lib comdlg32.lib comctl32.lib advapi32.lib shell32.lib ole32.lib uuid.lib /nologo /machine:I386 /nodefaultlib
9393
# SUBTRACT LINK32 /incremental:yes
9494

95-
RSC_PROJ= /l 0x409 /d "FEAT_GUI_W32"
96-
# ADD RSC /l 0x409 /d "FEAT_GUI_W32"
95+
RSC_PROJ= /l 0x409 /d "FEAT_GUI"
96+
# ADD RSC /l 0x409 /d "FEAT_GUI"
9797

9898
!IF "$(CFG)" == "Vim - Win32 Release gvim OLE"
9999

@@ -105,8 +105,8 @@ INTDIR=.\oleRel
105105
VIM=gvim
106106
EXTRAS="$(INTDIR)/if_ole.obj" "$(INTDIR)/vim.res" "$(INTDIR)/gui.obj" "$(INTDIR)/gui_w32.obj" "$(INTDIR)/gui_beval.obj" "$(INTDIR)/os_w32exe.obj"
107107

108-
CPP_PROJ=$(CPP_PROJ) /Zi /O2 /D "NDEBUG" /D "FEAT_GUI_W32" /D "DYNAMIC_GETTEXT" /D "FEAT_OLE" /Fd.\oleRel/ /Fo.\oleRel/
109-
# ADD CPP /Zi /O2 /D "NDEBUG" /D "FEAT_GUI_W32" /D "DYNAMIC_GETTEXT" /D "FEAT_OLE" /Fd.\oleRel/ /Fo.\oleRel/
108+
CPP_PROJ=$(CPP_PROJ) /Zi /O2 /D "NDEBUG" /D "FEAT_GUI" /D "DYNAMIC_GETTEXT" /D "FEAT_OLE" /Fd.\oleRel/ /Fo.\oleRel/
109+
# ADD CPP /Zi /O2 /D "NDEBUG" /D "FEAT_GUI" /D "DYNAMIC_GETTEXT" /D "FEAT_OLE" /Fd.\oleRel/ /Fo.\oleRel/
110110

111111
RSC_PROJ=$(RSC_PROJ) /I ".\oleRel" /d "NDEBUG" /d "FEAT_OLE" /fo.\oleRel\vim.res
112112
# ADD RSC /I ".\oleRel" /d "NDEBUG" /d "FEAT_OLE" /fo.\oleRel\vim.res
@@ -124,8 +124,8 @@ INTDIR=.\oleDbg
124124
VIM=gvimd
125125
EXTRAS="$(INTDIR)/if_ole.obj" "$(INTDIR)/vim.res" "$(INTDIR)/gui.obj" "$(INTDIR)/gui_w32.obj" "$(INTDIR)/gui_beval.obj" "$(INTDIR)/os_w32exe.obj"
126126

127-
CPP_PROJ=$(CPP_PROJ) /Zi /Od /D "_DEBUG" /D "FEAT_GUI_W32" /D "DYNAMIC_GETTEXT" /D "FEAT_OLE" /Fd.\oleDbg/ /Fo.\oleDbg/
128-
# ADD CPP /Zi /Od /D "_DEBUG" /D "FEAT_GUI_W32" /D "DYNAMIC_GETTEXT" /D "FEAT_OLE" /Fd.\oleDbg/ /Fo.\oleDbg/
127+
CPP_PROJ=$(CPP_PROJ) /Zi /Od /D "_DEBUG" /D "FEAT_GUI" /D "DYNAMIC_GETTEXT" /D "FEAT_OLE" /Fd.\oleDbg/ /Fo.\oleDbg/
128+
# ADD CPP /Zi /Od /D "_DEBUG" /D "FEAT_GUI" /D "DYNAMIC_GETTEXT" /D "FEAT_OLE" /Fd.\oleDbg/ /Fo.\oleDbg/
129129

130130
RSC_PROJ=$(RSC_PROJ) /I .\oleDbg /d "_DEBUG" /d "FEAT_OLE" /fo.\oleDbg\vim.res
131131
# ADD RSC /I .\oleDbg /d "_DEBUG" /d "FEAT_OLE" /fo.\oleDbg\vim.res
@@ -144,8 +144,8 @@ INTDIR=.\gRel
144144
VIM=gvim
145145
EXTRAS="$(INTDIR)/vim.res" "$(INTDIR)/gui.obj" "$(INTDIR)/gui_w32.obj" "$(INTDIR)/gui_beval.obj" "$(INTDIR)/os_w32exe.obj"
146146

147-
CPP_PROJ=$(CPP_PROJ) /Zi /O2 /D "NDEBUG" /D "FEAT_GUI_W32" /Fd.\gRel/ /Fo.\gRel/
148-
# ADD CPP /Zi /O2 /D "NDEBUG" /D "FEAT_GUI_W32" /Fd.\gRel/ /Fo.\gRel/
147+
CPP_PROJ=$(CPP_PROJ) /Zi /O2 /D "NDEBUG" /D "FEAT_GUI" /Fd.\gRel/ /Fo.\gRel/
148+
# ADD CPP /Zi /O2 /D "NDEBUG" /D "FEAT_GUI" /Fd.\gRel/ /Fo.\gRel/
149149

150150
RSC_PROJ=$(RSC_PROJ) /d "NDEBUG" /fo.\gRel\vim.res
151151
# ADD RSC /d "NDEBUG" /fo.\gRel\vim.res
@@ -163,8 +163,8 @@ INTDIR=.\gDbg
163163
VIM=gvimd
164164
EXTRAS="$(INTDIR)/vim.res" "$(INTDIR)/gui.obj" "$(INTDIR)/gui_w32.obj" "$(INTDIR)/gui_beval.obj" "$(INTDIR)/os_w32exe.obj"
165165

166-
CPP_PROJ=$(CPP_PROJ) /Zi /Od /D "_DEBUG" /D "FEAT_GUI_W32" /Fd.\gDbg/ /Fo.\gDbg/
167-
# ADD CPP /Zi /Od /D "_DEBUG" /D "FEAT_GUI_W32" /Fd.\gDbg/ /Fo.\gDbg/
166+
CPP_PROJ=$(CPP_PROJ) /Zi /Od /D "_DEBUG" /D "FEAT_GUI" /Fd.\gDbg/ /Fo.\gDbg/
167+
# ADD CPP /Zi /Od /D "_DEBUG" /D "FEAT_GUI" /Fd.\gDbg/ /Fo.\gDbg/
168168

169169
RSC_PROJ=$(RSC_PROJ) /d "_DEBUG" /fo.\gDbg\vim.res
170170
# ADD RSC /d "_DEBUG" /fo.\gDbg\vim.res
@@ -508,7 +508,7 @@ SOURCE=.\if_ole.cpp
508508
# Begin Custom Build
509509

510510
"$(INTDIR)\if_ole.obj" : $(SOURCE) "$(INTDIR)" "$(INTDIR)\if_ole.h"
511-
cl.exe /nologo /MT /W3 /GX /I ".\proto" /D "WIN32" /c /Zi /O2 /D "NDEBUG" /D "FEAT_GUI_W32" /D "FEAT_OLE" /Fd.\oleRel/ /Fo.\oleRel/ /I ".\oleRel" .\if_ole.cpp
511+
cl.exe /nologo /MT /W3 /GX /I ".\proto" /D "WIN32" /c /Zi /O2 /D "NDEBUG" /D "FEAT_GUI" /D "FEAT_OLE" /Fd.\oleRel/ /Fo.\oleRel/ /I ".\oleRel" .\if_ole.cpp
512512
@rem This is the default rule with /I "$(IntDir)" added
513513

514514
# End Custom Build
@@ -519,7 +519,7 @@ SOURCE=.\if_ole.cpp
519519
# Begin Custom Build
520520

521521
"$(INTDIR)\if_ole.obj" : $(SOURCE) "$(INTDIR)" "$(INTDIR)\if_ole.h"
522-
cl.exe /nologo /MT /W3 /GX /I ".\proto" /D "WIN32" /c /Zi /Od /D "_DEBUG" /D "FEAT_GUI_W32" /D "FEAT_OLE" /Fd.\oleDbg/ /Fo.\oleDbg/ /I ".\oleDbg" .\if_ole.cpp
522+
cl.exe /nologo /MT /W3 /GX /I ".\proto" /D "WIN32" /c /Zi /Od /D "_DEBUG" /D "FEAT_GUI" /D "FEAT_OLE" /Fd.\oleDbg/ /Fo.\oleDbg/ /I ".\oleDbg" .\if_ole.cpp
523523
@rem This is the default rule with /I "$(IntDir)" added
524524

525525
# End Custom Build

src/Make_mvc.mak

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -791,8 +791,8 @@ OBJ = $(OBJ) $(OUTDIR)\dimm_i.obj $(OUTDIR)\glbl_ime.obj
791791

792792
!if "$(GUI)" == "yes"
793793
SUBSYSTEM = windows
794-
CFLAGS = $(CFLAGS) -DFEAT_GUI_W32
795-
RCFLAGS = $(RCFLAGS) -DFEAT_GUI_W32
794+
CFLAGS = $(CFLAGS) -DFEAT_GUI
795+
RCFLAGS = $(RCFLAGS) -DFEAT_GUI
796796
VIM = g$(VIM)
797797
GUI_INCL = \
798798
gui.h

src/beval.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ typedef struct BalloonEvalStruct
4343
int y;
4444
unsigned int state; /* Button/Modifier key state */
4545
# else
46-
# if !defined(FEAT_GUI_W32)
46+
# if !defined(FEAT_GUI_MSWIN)
4747
Widget target; /* widget we are monitoring */
4848
Widget balloonShell;
4949
Widget balloonLabel;
@@ -63,7 +63,7 @@ typedef struct BalloonEvalStruct
6363
BeState showState; /* tells us whats currently going on */
6464
# endif
6565
# endif
66-
# if !defined(FEAT_GUI_GTK) && !defined(FEAT_GUI_W32)
66+
# if !defined(FEAT_GUI_GTK) && !defined(FEAT_GUI_MSWIN)
6767
Dimension screen_width; /* screen width in pixels */
6868
Dimension screen_height; /* screen height in pixels */
6969
# endif
@@ -76,7 +76,7 @@ typedef struct BalloonEvalStruct
7676
int *vts; // vartabstop setting for this buffer
7777
#endif
7878
char_u *msg;
79-
#ifdef FEAT_GUI_W32
79+
#ifdef FEAT_GUI_MSWIN
8080
void *tofree;
8181
#endif
8282
} BalloonEval;

src/blowfish.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ typedef union {
3434
char_u uc[8];
3535
} block8;
3636

37-
#if defined(WIN3264)
37+
#if defined(MSWIN)
3838
/* MS-Windows is always little endian */
3939
#else
4040
# ifdef HAVE_CONFIG_H

src/channel.c

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#endif
2121

2222
/* Note: when making changes here also adjust configure.ac. */
23-
#ifdef WIN32
23+
#ifdef MSWIN
2424
/* WinSock API is separated from C API, thus we can't use read(), write(),
2525
* errno... */
2626
# define SOCK_ERRNO errno = WSAGetLastError()
@@ -65,7 +65,7 @@ static int safe_to_invoke_callback = 0;
6565

6666
static char *part_names[] = {"sock", "out", "err", "in"};
6767

68-
#ifdef WIN32
68+
#ifdef MSWIN
6969
static int
7070
fd_read(sock_T fd, char *buf, size_t len)
7171
{
@@ -234,7 +234,7 @@ ch_error(channel_T *ch, const char *fmt, ...)
234234
}
235235
}
236236

237-
#ifdef _WIN32
237+
#ifdef MSWIN
238238
# undef PERROR
239239
# define PERROR(msg) (void)semsg("%s: %s", msg, strerror_win32(errno))
240240

@@ -687,7 +687,7 @@ channel_open(
687687
int sd = -1;
688688
struct sockaddr_in server;
689689
struct hostent *host;
690-
#ifdef WIN32
690+
#ifdef MSWIN
691691
u_short port = port_in;
692692
u_long val = 1;
693693
#else
@@ -696,7 +696,7 @@ channel_open(
696696
channel_T *channel;
697697
int ret;
698698

699-
#ifdef WIN32
699+
#ifdef MSWIN
700700
channel_init_winsock();
701701
#endif
702702

@@ -758,7 +758,7 @@ channel_open(
758758
{
759759
/* Make connect() non-blocking. */
760760
if (
761-
#ifdef _WIN32
761+
#ifdef MSWIN
762762
ioctlsocket(sd, FIONBIO, &val) < 0
763763
#else
764764
fcntl(sd, F_SETFL, O_NONBLOCK) < 0
@@ -804,14 +804,14 @@ channel_open(
804804

805805
/* If connect() didn't finish then try using select() to wait for the
806806
* connection to be made. For Win32 always use select() to wait. */
807-
#ifndef WIN32
807+
#ifndef MSWIN
808808
if (errno != ECONNREFUSED)
809809
#endif
810810
{
811811
struct timeval tv;
812812
fd_set rfds;
813813
fd_set wfds;
814-
#ifndef WIN32
814+
#ifndef MSWIN
815815
int so_error = 0;
816816
socklen_t so_error_len = sizeof(so_error);
817817
struct timeval start_tv;
@@ -824,7 +824,7 @@ channel_open(
824824

825825
tv.tv_sec = waitnow / 1000;
826826
tv.tv_usec = (waitnow % 1000) * 1000;
827-
#ifndef WIN32
827+
#ifndef MSWIN
828828
gettimeofday(&start_tv, NULL);
829829
#endif
830830
ch_log(channel,
@@ -842,7 +842,7 @@ channel_open(
842842
return NULL;
843843
}
844844

845-
#ifdef WIN32
845+
#ifdef MSWIN
846846
/* On Win32: select() is expected to work and wait for up to
847847
* "waitnow" msec for the socket to be open. */
848848
if (FD_ISSET(sd, &wfds))
@@ -893,7 +893,7 @@ channel_open(
893893
#endif
894894
}
895895

896-
#ifndef WIN32
896+
#ifndef MSWIN
897897
if (waittime > 1 && elapsed_msec < waittime)
898898
{
899899
/* The port isn't ready but we also didn't get an error.
@@ -930,7 +930,7 @@ channel_open(
930930

931931
if (waittime >= 0)
932932
{
933-
#ifdef _WIN32
933+
#ifdef MSWIN
934934
val = 0;
935935
ioctlsocket(sd, FIONBIO, &val);
936936
#else
@@ -1029,7 +1029,7 @@ ch_close_part(channel_T *channel, ch_part_T part)
10291029
&& (part == PART_OUT || channel->CH_OUT_FD != *fd)
10301030
&& (part == PART_ERR || channel->CH_ERR_FD != *fd))
10311031
{
1032-
#ifdef WIN32
1032+
#ifdef MSWIN
10331033
if (channel->ch_named_pipe)
10341034
DisconnectNamedPipe((HANDLE)fd);
10351035
#endif
@@ -1427,7 +1427,7 @@ can_write_buf_line(channel_T *channel)
14271427
in_part->ch_block_write = 1;
14281428

14291429
/* TODO: Win32 implementation, probably using WaitForMultipleObjects() */
1430-
#ifndef WIN32
1430+
#ifndef MSWIN
14311431
{
14321432
# if defined(HAVE_SELECT)
14331433
struct timeval tval;
@@ -1759,7 +1759,7 @@ channel_get_all(channel_T *channel, ch_part_T part, int *outlen)
17591759
{
17601760
if (*p == NUL)
17611761
*p = NL;
1762-
#ifdef WIN32
1762+
#ifdef MSWIN
17631763
else if (*p == 0x1b)
17641764
{
17651765
// crush the escape sequence OSC 0/1/2: ESC ]0;
@@ -2064,7 +2064,7 @@ channel_parse_json(channel_T *channel, ch_part_T part)
20642064
(int)buflen);
20652065
reader.js_used = 0;
20662066
chanpart->ch_wait_len = buflen;
2067-
#ifdef WIN32
2067+
#ifdef MSWIN
20682068
chanpart->ch_deadline = GetTickCount() + 100L;
20692069
#else
20702070
gettimeofday(&chanpart->ch_deadline, NULL);
@@ -2079,7 +2079,7 @@ channel_parse_json(channel_T *channel, ch_part_T part)
20792079
else
20802080
{
20812081
int timeout;
2082-
#ifdef WIN32
2082+
#ifdef MSWIN
20832083
timeout = GetTickCount() > chanpart->ch_deadline;
20842084
#else
20852085
{
@@ -3198,7 +3198,7 @@ channel_wait(channel_T *channel, sock_T fd, int timeout)
31983198
if (timeout > 0)
31993199
ch_log(channel, "Waiting for up to %d msec", timeout);
32003200

3201-
# ifdef WIN32
3201+
# ifdef MSWIN
32023202
if (fd != channel->CH_SOCK_FD)
32033203
{
32043204
DWORD nread;
@@ -3554,7 +3554,7 @@ channel_read_json_block(
35543554
timeout = timeout_arg;
35553555
if (chanpart->ch_wait_len > 0)
35563556
{
3557-
#ifdef WIN32
3557+
#ifdef MSWIN
35583558
timeout = chanpart->ch_deadline - GetTickCount() + 1;
35593559
#else
35603560
{
@@ -3680,7 +3680,7 @@ common_channel_read(typval_T *argvars, typval_T *rettv, int raw, int blob)
36803680
free_job_options(&opt);
36813681
}
36823682

3683-
# if defined(WIN32) || defined(FEAT_GUI_X11) || defined(FEAT_GUI_GTK) \
3683+
# if defined(MSWIN) || defined(FEAT_GUI_X11) || defined(FEAT_GUI_GTK) \
36843684
|| defined(PROTO)
36853685
/*
36863686
* Lookup the channel from the socket. Set "partp" to the fd index.
@@ -3707,7 +3707,7 @@ channel_fd2channel(sock_T fd, ch_part_T *partp)
37073707
}
37083708
# endif
37093709

3710-
# if defined(WIN32) || defined(FEAT_GUI) || defined(PROTO)
3710+
# if defined(MSWIN) || defined(FEAT_GUI) || defined(PROTO)
37113711
/*
37123712
* Check the channels for anything that is ready to be read.
37133713
* The data is put in the read queue.
@@ -3772,7 +3772,7 @@ channel_set_nonblock(channel_T *channel, ch_part_T part)
37723772

37733773
if (fd != INVALID_FD)
37743774
{
3775-
#ifdef _WIN32
3775+
#ifdef MSWIN
37763776
u_long val = 1;
37773777

37783778
ioctlsocket(fd, FIONBIO, &val);
@@ -3853,7 +3853,7 @@ channel_send(
38533853
else
38543854
{
38553855
res = fd_write(fd, (char *)buf, len);
3856-
#ifdef WIN32
3856+
#ifdef MSWIN
38573857
if (channel->ch_named_pipe && res < 0)
38583858
{
38593859
DisconnectNamedPipe((HANDLE)fd);
@@ -4213,7 +4213,7 @@ channel_poll_check(int ret_in, void *fds_in)
42134213
}
42144214
# endif /* UNIX && !HAVE_SELECT */
42154215

4216-
# if (!defined(WIN32) && defined(HAVE_SELECT)) || defined(PROTO)
4216+
# if (!defined(MSWIN) && defined(HAVE_SELECT)) || defined(PROTO)
42174217

42184218
/*
42194219
* The "fd_set" type is hidden to avoid problems with the function proto.
@@ -4313,7 +4313,7 @@ channel_select_check(int ret_in, void *rfds_in, void *wfds_in)
43134313

43144314
return ret;
43154315
}
4316-
# endif /* !WIN32 && HAVE_SELECT */
4316+
# endif /* !MSWIN && HAVE_SELECT */
43174317

43184318
/*
43194319
* Execute queued up commands.
@@ -5039,7 +5039,7 @@ get_job_options(typval_T *tv, jobopt_T *opt, int supported, int supported2)
50395039
break;
50405040
opt->jo_cwd = tv_get_string_buf_chk(item, opt->jo_cwd_buf);
50415041
if (opt->jo_cwd == NULL || !mch_isdir(opt->jo_cwd)
5042-
#ifndef WIN32 // Win32 directories don't have the concept of "executable"
5042+
#ifndef MSWIN // Win32 directories don't have the concept of "executable"
50435043
|| mch_access((char *)opt->jo_cwd, X_OK) != 0
50445044
#endif
50455045
)
@@ -5199,7 +5199,7 @@ job_free_contents(job_T *job)
51995199
#ifdef UNIX
52005200
vim_free(job->jv_termsig);
52015201
#endif
5202-
#ifdef WIN3264
5202+
#ifdef MSWIN
52035203
vim_free(job->jv_tty_type);
52045204
#endif
52055205
free_callback(job->jv_exit_cb, job->jv_exit_partial);
@@ -5971,7 +5971,7 @@ job_info(job_T *job, dict_T *dict)
59715971
#ifdef UNIX
59725972
dict_add_string(dict, "termsig", job->jv_termsig);
59735973
#endif
5974-
#ifdef WIN3264
5974+
#ifdef MSWIN
59755975
dict_add_string(dict, "tty_type", job->jv_tty_type);
59765976
#endif
59775977

0 commit comments

Comments
 (0)