patch 8.2.0472: terminal highlight name is set twice, leaking memory

brammool · brammool · commit 360bdbda8179 · 2020-03-28T22:37:14.000+01:00
Problem:    Terminal highlight name is set twice, leaking memory.
Solution:   Delete one.
diff --git a/src/terminal.c b/src/terminal.c
@@ -6925,8 +6925,6 @@ term_and_job_init(
 	jobopt_T    *orig_opt UNUSED)
 {
     term->tl_arg0_cmd = NULL;
-    if (opt->jo_set2 & JO2_TERM_HIGHLIGHT)
-	term->tl_highlight_name = vim_strsave(opt->jo_term_highlight);
 
     if (create_vterm(term, term->tl_rows, term->tl_cols) == FAIL)
 	return FAIL;
diff --git a/src/version.c b/src/version.c
@@ -738,6 +738,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    472,
 /**/
     471,
 /**/

Original file line number	Diff line number	Diff line change
`@@ -6925,8 +6925,6 @@ term_and_job_init(`
`6925`	`6925`	`jobopt_T *orig_opt UNUSED)`
`6926`	`6926`	`{`
`6927`	`6927`	`term->tl_arg0_cmd = NULL;`
`6928`		`- if (opt->jo_set2 & JO2_TERM_HIGHLIGHT)`
`6929`		`- term->tl_highlight_name = vim_strsave(opt->jo_term_highlight);`
`6930`	`6928`
`6931`	`6929`	`if (create_vterm(term, term->tl_rows, term->tl_cols) == FAIL)`
`6932`	`6930`	`return FAIL;`