Skip to content

Commit 24a5ac5

Browse files
committed
patch 8.1.1499: ruler not updated after popup window was removed
Problem: Ruler not updated after popup window was removed. Solution: use popup_mask in screen_puts().
1 parent c024b46 commit 24a5ac5

5 files changed

Lines changed: 40 additions & 1 deletion

File tree

src/screen.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7897,7 +7897,11 @@ screen_puts_len(
78977897
|| ScreenAttrs[off] != attr
78987898
|| exmode_active;
78997899

7900-
if (need_redraw || force_redraw_this)
7900+
if ((need_redraw || force_redraw_this)
7901+
#ifdef FEAT_TEXT_PROP
7902+
&& popup_mask[row * screen_Columns + col] <= screen_zindex
7903+
#endif
7904+
)
79017905
{
79027906
#if defined(FEAT_GUI) || defined(UNIX)
79037907
/* The bold trick makes a single row of pixels appear in the next
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
> +0&#ffffff0@74
2+
|~+0#4040ff13&| @73
3+
|~| @73
4+
|~| @73
5+
|~| @73
6+
|~| @73
7+
|~| @52|o+0#0000001#ffd7ff255|t|h|e|r| |t|a|b| @11
8+
|~+0#4040ff13#ffffff0| @52|a+0#0000001#ffd7ff255| |c+0#ff404010&|o|m@1|e|n|t| +0#0000001&|l|i|n|e| @6
9+
|:+0#0000000#ffffff0|c|a|l@1| |p|o|p|u|p|_|m|o|v|e|(|p|o|p|u|p|w|i|n|,| |{|'|l|i|n|e|'|:| |7|,| |'|c|o|l|'|:| |5@1|}|)| @3|t+0#0000001#ffd7ff255|h|i|s| |l|i|n|e| |w|i|l@1| |n|o|t| |f|i
10+
| +0#0000000#ffffff0@53|t+0#0000001#ffd7ff255| |h|e|r|e| @14
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
>x+0&#ffffff0@2| @71
2+
|~+0#4040ff13&| @73
3+
|~| @73
4+
|~| @73
5+
|~| @73
6+
|~| @73
7+
|~| @73
8+
|~| @73
9+
| +0#0000000&@74
10+
@57|1|,|1| @10|A|l@1|

src/testdir/test_popupwin.vim

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,19 @@ func Test_simple_popup()
5151
call term_sendkeys(buf, ":redraw\<CR>")
5252
call VerifyScreenDump(buf, 'Test_popupwin_06', {})
5353

54+
" move popup over ruler
55+
call term_sendkeys(buf, ":set cmdheight=2\<CR>")
56+
call term_sendkeys(buf, ":call popup_move(popupwin, {'line': 7, 'col': 55})\<CR>")
57+
call VerifyScreenDump(buf, 'Test_popupwin_07', {})
58+
59+
" clear all popups after moving the cursor a bit, so that ruler is updated
60+
call term_sendkeys(buf, "axxx\<Esc>")
61+
call term_wait(buf)
62+
call term_sendkeys(buf, "0")
63+
call term_wait(buf)
64+
call term_sendkeys(buf, ":popupclear\<CR>")
65+
call VerifyScreenDump(buf, 'Test_popupwin_08', {})
66+
5467
" clean up
5568
call StopVimInTerminal(buf)
5669
call delete('XtestPopup')

src/version.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -767,6 +767,8 @@ static char *(features[]) =
767767

768768
static int included_patches[] =
769769
{ /* Add new patch number below this line */
770+
/**/
771+
1499,
770772
/**/
771773
1498,
772774
/**/

0 commit comments

Comments
 (0)