Fix disk image build target (macvim-dmg) permission issues on Travis

create-dmg uses osascript calls to prettify the created dmg file, which
has not been working in Travis CI for a while since it would pop up a
dialog box asking for permission in the later macOS versions, and
there's no way to interact with it in CI. The old version of create-dmg
silently handles the failure but the new version just fails the build,
so we need to manually pass in --skip-jenkins flag to skip the prettify
step.

This is still ok, because currently the maintainer still has to manually
re-build and re-sign the dmg file locally after Travis built it to add
signing and notarization to the app, so the dmg file built by Travis is
just an intermediate step, and not going to be used for the final
release.

Author: ychin

.travis.yml

@@ -122,7 +122,8 @@ jobs:
       <<: *caches
       script: skip
       before_deploy:
-        - make -C src macvim-dmg
+        # Use the --skip-jenkins flag to skip the prettify osascript calls which will fail due to permission issues in Travis CI's Mac environment.
+        - make -C src macvim-dmg CREATEDMG_FLAGS=--skip-jenkins
       deploy:
         provider: releases
         token:

src/Makefile

@@ -3747,7 +3747,7 @@ macvim-dmg:
 		--icon-size 80 \
 		--icon MacVim.app 240 320 \
 		--app-drop-link 410 320 \
-		$(RELEASEDIR)/$(DMGFILE) $(DMGDIR)
+		$(CREATEDMG_FLAGS) $(RELEASEDIR)/$(DMGFILE) $(DMGDIR)
 
 macvimclean:
 	if test -d MacVim; then \
@@ -3758,8 +3758,8 @@ macvimclean:
 macvim-dmg-release: macvim-signed macvim-dmg
 	MacVim/scripts/sign-developer-id $(RELEASEDIR)/MacVim.dmg $(ENTITLEMENTS)
 	MacVim/scripts/notarize-dmg $(RELEASEDIR)/MacVim.dmg
-	echo "--------------------"
-	echo "Release MacVim built!"
+	@echo "----------------------------------------"
+	@echo "Release MacVim built!"
 
 # Install only language files to a dest folder. Subset of "install-languages".
 macvim-install-languages: