Skip to content

Commit 0dcd39b

Browse files
committed
patch 8.2.2458: Coverity warns for :retab using freed memory
Problem: Coverity warns for :retab using freed memory. Solution: Use the updated line pointer when moving text properties.
1 parent 4dba042 commit 0dcd39b

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

src/indent.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1662,7 +1662,9 @@ ex_retab(exarg_T *eap)
16621662
ptr = new_line + start_col;
16631663
for (col = 0; col < len; col++)
16641664
ptr[col] = (col < num_tabs) ? '\t' : ' ';
1665-
ml_replace(lnum, new_line, FALSE);
1665+
if (ml_replace(lnum, new_line, FALSE) == OK)
1666+
// "new_line" may have been copied
1667+
new_line = curbuf->b_ml.ml_line_ptr;
16661668
if (first_line == 0)
16671669
first_line = lnum;
16681670
last_line = lnum;

src/version.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -750,6 +750,8 @@ static char *(features[]) =
750750

751751
static int included_patches[] =
752752
{ /* Add new patch number below this line */
753+
/**/
754+
2458,
753755
/**/
754756
2457,
755757
/**/

0 commit comments

Comments
 (0)