Skip to content

[BUG] Confusing behavior around overwriting authentication settings #303

@azban

Description

@azban

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

in the init script, there are some actions that make it hard to debug what is going on.

  1. If you do not specify the USER and PASS environment variables, then it automatically sets rpc-authentication-enabled to false.
  2. If you do not specify the WHITELIST environment variables, then it automatically set rpc-whitelist-enabled to false.

i have seen other issues in the repo where the maintainers seem to think this is the best approach. i think this is limiting for 2 reasons:

  1. it could be preferable to provide the password in the way that transmission allows by setting it directly in settings.json and then is salted on startup. otherwise, plaintext passwords need to be used in docker configuration or initialization. with the current setup, this is impossible.
  2. it is a nice experience for a user to be able to use an existing settings.json file that they use in other deployments

this could be done in a backwards-compatible way if we added another environment variable to not automatically override these settings.

either way, it would at least be good to be explicit about what is happening in the documentation, and to add some logging to the init script so that users could see that what values are getting written by inference of environment variables. i'm happy to put up a PR with some guidance on if the option to not override is desirable.

Expected Behavior

No response

Steps To Reproduce

  1. stop container
  2. modify certain keys in settings.json
  3. start container
  4. unexpected overrides

Environment

CPU architecture

x86-64

Docker creation

docker-compose

Container logs

no relevant logs

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions