[BUG] Screen Settings do not survive a Browser reload

[hgw77]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

If I try to set the Screen Settings Presets in the selkies Settings, like 1920x1080 or a custom resolution like 1600x1000 the settings do not survive a reload of the browser.

Tested that with the latest webtop debian xfce image in Chromium Browser

Expected Behavior

The settings survives a reload that I do not need to set it every time

Steps To Reproduce

1. Open Selkies Dialog in the Browser
2. Go to Screen Settings and set a resolution
3. Reload the browser

Environment

Browser Chromium

Docker creation

-

Container logs

-

[thelamer]

Yeah manual screen settings are not stored in local storage and need to be set every time crf looks like it can reset in specific scenarios as well, this rolls into the whole settings overhaul, we need levers with server overrides and strict controls for all clientside settings so people can let randoms use this stuff (as is client is the authority and can request the server do anything)
#36

[thelamer]

I unified all the settings and have tested this to death now, it is solid, the only gotcha is on upgrade people are gonna lose their old settings but once they set them it will be tied to the window URL and be locked in.
selkies-project/selkies@fb2d579

I have a couple other issues to close out but expect this to be in the base after the weekend.

[thelamer]

This is in the base, downstream images building out now