[BUG] Pasting Spam/Hangup

[wolveix]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

Since rebasing to Selkies, hitting CMD + V to paste causes the clipboard to spam indefinitely until clicking somewhere or hitting escape.

Expected Behavior

Hitting CMD + V should paste the contents of the clipboard once, as before.

Steps To Reproduce

1. Press CMD + V while editing a book's title in the table view

Environment

- OS: Debian 12 (Proxmox 8.4.5)
- How docker service was installed: Docker was installed following the normal Debian installation instructions

CPU architecture

x86-64

Docker creation

calibre-library:
    container_name: calibre-library
    image: lscr.io/linuxserver/calibre:latest
    networks:
      petaluma: {ipv4_address: 10.111.0.10}
    security_opt:
      - seccomp:unconfined #optional
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=Etc/UTC
      - PASSWORD= #optional
      - CLI_ARGS= #optional
      - NO_DECOR=true
      - NO_FULL=true
      - SUBFOLDER=/media/calibre-library/
      - TITLE=Calibre Library
    volumes:
      - /opt/media/calibre-library/config:/config
      - /opt/media/calibre-library/plugins:/plugins
      - /mnt/big_data/media/Books:/data/books
      - /mnt/big_data/media/uploads/books:/data/uploads
    restart: unless-stopped

Container logs

Logs were too long to paste:
container.log

Figured I'd grep for "clipboard" on the off chance there was something obvious:

❯ cat container.log | grep clipboard
INFO:webrtc_input:Starting clipboard monitor
WARNING:webrtc_input:No clipboard content to send
WARNING:webrtc_input:No clipboard content to send
WARNING:webrtc_input:No clipboard content to send
WARNING:webrtc_input:No clipboard content to send
WARNING:webrtc_input:No clipboard content to send
WARNING:webrtc_input:No clipboard content to send
WARNING:webrtc_input:No clipboard content to send
WARNING:webrtc_input:No clipboard content to send
WARNING:webrtc_input:No clipboard content to send
INFO:webrtc_input:Sending clipboard content, length: 24
INFO:webrtc_input:Sending clipboard content, length: 22

[github-actions]

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

[github-actions]

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

[thelamer]

I finally got an OSX vm so I can replicate this(have not tested yet, but I can), just as an FYI ctl+c and ctrl+v is what linux actually uses so if you can move your pinky 1 inch to the left that should be a temp workaround while this is looked at.

[wolveix]

@thelamer yeah I'm familiar, but I don't have CTRL in a convenient location as I'm using a Kinesis Advantage 360 with custom binds :P But you're right, I can absolutely use that as a workaround in the meantime :)

[thelamer]

This is resolved in latest please pull and confirm, the one thing you will not be able to do is hold command and paste multiple times as far as I can tell that would be impossible.(JavaScript translation of the command key has no key up so we need to assume keyup on the action)

[wolveix]

Hey @thelamer, thanks for the quick fix! I just tested it and it's mostly fixed; however, if you continue to hold the CMD key, it'll continue to spam as before. Additionally, copy & pasting seems to be a little temperamental. If you double-click into a field, hit CMD + A to select everything, and then hit CMD + V (without releasing CMD in between), it'll just type V. From testing this a little further, my assumption is that after registering the first multipress, Selkies ignores future commands until CMD is released and pressed again.

I assume both of these are issues stemming from your JavaScript comment (I admittedly glossed over that until I'd finished typing this out), but figured I'd mention them. This wasn't an issue with noVNC before, but it's not a huge deal, just takes a bit of getting used to!

[thelamer]

This is the best I can do and I am fairly confident in that. ctl is the best bet but this command remapping is temperamental and we have to make many assumptions.
https://stackoverflow.com/questions/25438608/javascript-keyup-isnt-called-when-command-and-another-is-pressed
This is a known thing, and because I am tracking key down keyup and not raw input events (breaks international keyboards in many cases) this is the only patch that can really be applied)
You need to understand that this input subsystem fixes many issues for other bugs that you are not aware of like Nordic keyboard maps, Cyrillic characters, and Chinese pinyan.
Long way of saying I don't think I can take it any further we are doing the best we can with the input events that we are presented.

[wolveix]

@thelamer I completely understand, and to be clear, I wasn't complaining 😅 I really appreciate your hard work!