Skip to content

Commit 4c4acb2

Browse files
authored
nemo-places-sidebar.c: Restore visibility of mounts with no (#3670)
associated volume. We started skipping these in 9381561, but there are some legitimate instances where these should be shown, and are still shown in other areas of Nemo (the desktop, the move/copy-to submenus). One case is Virtualbox shared folders. If sharing a host folder with a guest and no mount point is provided, guest-additions mounts this in /media and it shows up in the GVolumeMonitor (and desktop, etc...). If a mount-point *is* provided, and that folder exists on the guest, the mount is *not* visible in a GVolumeMonitor, and will not be visible in Nemo, except as a normal folder. This seems logical. Another seems to be cifs/samba mounts, depending on how they're mounted. Using smb:// uris causes these to appear in the Network section, but using mount they no longer appear in the sidebar in any section. The other part of that commit, skipping shadowed mounts, remains correct - and these other places mentioned above were already filtering these out as well. Ref: linuxmint/mint22.3-beta#67.
1 parent 7c501f1 commit 4c4acb2

1 file changed

Lines changed: 15 additions & 0 deletions

File tree

src/nemo-places-sidebar.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -987,6 +987,21 @@ update_places (NemoPlacesSidebar *sidebar)
987987
}
988988
}
989989

990+
icon = nemo_get_mount_icon_name (mount);
991+
mount_uri = g_file_get_uri (root);
992+
name = g_mount_get_name (mount);
993+
tooltip = g_file_get_parse_name (root);
994+
place_info = new_place_info (PLACES_MOUNTED_VOLUME,
995+
SECTION_DEVICES,
996+
name, icon, mount_uri,
997+
NULL, NULL, mount, 0, tooltip, 0, FALSE);
998+
place_infos = g_list_prepend (place_infos, place_info);
999+
1000+
g_free (icon);
1001+
g_free (name);
1002+
g_free (mount_uri);
1003+
g_free (tooltip);
1004+
9901005
g_object_unref (root);
9911006
g_object_unref (mount);
9921007
}

0 commit comments

Comments
 (0)