xdg-shell/popup: Reset 'dismissed-by-client' state when remapping

Sunderland93 · mtwebster · commit ea04651e2fbb · 2025-11-16T20:05:44.000-05:00
A popup surface can be remapped multiple times using the same
wl_surface, if a new xdg_popup object is created. To properly handle
this, we need to reset the 'dismissed_by_client' boolean to false, as
otherwise we won't allow new buffer commits.
diff --git a/src/wayland/meta-wayland-xdg-shell.c b/src/wayland/meta-wayland-xdg-shell.c
@@ -1059,6 +1059,7 @@ finish_popup_setup (MetaWaylandXdgPopup *xdg_popup)
 
   xdg_popup->setup.parent_surface = NULL;
   xdg_popup->setup.grab_seat = NULL;
+  xdg_popup->dismissed_by_client = FALSE;
 
   if (!meta_wayland_surface_get_window (parent_surface))
     {

Original file line number	Diff line number	Diff line change
`@@ -1059,6 +1059,7 @@ finish_popup_setup (MetaWaylandXdgPopup *xdg_popup)`
`1059`	`1059`
`1060`	`1060`	`xdg_popup->setup.parent_surface = NULL;`
`1061`	`1061`	`xdg_popup->setup.grab_seat = NULL;`
	`1062`	`+ xdg_popup->dismissed_by_client = FALSE;`
`1062`	`1063`
`1063`	`1064`	`if (!meta_wayland_surface_get_window (parent_surface))`
`1064`	`1065`	`{`