Fix localization in KeybindingWidgets.py

Fixes linuxmint/cinnamon-spices-applets#4235

Author: clefebvre

cinnamon.pot

@@ -8,7 +8,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2026-01-05 21:46+0200\n"
+"POT-Creation-Date: 2026-01-05 22:02+0200\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <[email protected]>\n"
@@ -89,7 +89,7 @@ msgstr ""
 #: files/usr/share/cinnamon/cinnamon-settings-users/cinnamon-settings-users.py:385
 #: files/usr/share/cinnamon/cinnamon-settings-users/cinnamon-settings-users.py:451
 #: files/usr/share/cinnamon/cinnamon-settings-users/cinnamon-settings-users.py:656
-#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:331
+#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:155
 #: files/usr/share/cinnamon/cinnamon-settings/modules/cs_keyboard.py:762
 #: files/usr/share/cinnamon/cinnamon-settings/modules/cs_startup.py:771
 msgid "Cancel"
@@ -3824,67 +3824,69 @@ msgstr ""
 msgid "Choose the assignment you wish to keep. The others will be cleared."
 msgstr ""
 
-#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:146
+#. l10n constants - get them translated here so they use Cinnamon's gettext
+#. context
+#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:147
 msgid "Click to set a new accelerator key."
 msgstr ""
 
-#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:147
+#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:148
 msgid "Press Escape or click again to cancel the operation."
 msgstr ""
 
-#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:148
+#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:149
 msgid "Press Backspace to clear the existing keybinding."
 msgstr ""
 
-#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:183
+#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:150
 msgid "unassigned"
 msgstr ""
 
-#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:227
+#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:151
 msgid "Pick an accelerator"
 msgstr ""
 
-#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:332
-msgid "Continue"
-msgstr ""
-
-#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:336
+#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:152
 #, python-format
 msgid ""
 "\n"
 "This key combination, '<b>%s</b>' should not be used because it would become impossible to type using this key. "
 msgstr ""
 
-#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:337
+#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:153
 msgid ""
 "Please try again using a modifier key such as Control, Alt or Super (Windows key).\n"
 "\n"
 msgstr ""
 
-#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:338
+#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:154
 msgid ""
 "Continue only if you are certain this is what you want, otherwise press "
 "cancel.\n"
 msgstr ""
 
-#: files/usr/share/cinnamon/cinnamon-settings/bin/SettingsWidgets.py:176
+#: files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py:156
+msgid "Continue"
+msgstr ""
+
+#: files/usr/share/cinnamon/cinnamon-settings/bin/SettingsWidgets.py:179
 msgid "Checking dependencies"
 msgstr ""
 
-#: files/usr/share/cinnamon/cinnamon-settings/bin/SettingsWidgets.py:177
+#: files/usr/share/cinnamon/cinnamon-settings/bin/SettingsWidgets.py:180
 #, python-format
 msgid "Please install: %s"
 msgstr ""
 
-#: files/usr/share/cinnamon/cinnamon-settings/bin/SettingsWidgets.py:376
+#: files/usr/share/cinnamon/cinnamon-settings/bin/SettingsWidgets.py:379
 msgid "_Cancel"
 msgstr ""
 
-#: files/usr/share/cinnamon/cinnamon-settings/bin/SettingsWidgets.py:377
+#: files/usr/share/cinnamon/cinnamon-settings/bin/SettingsWidgets.py:380
 msgid "_Open"
 msgstr ""
 
-#: files/usr/share/cinnamon/cinnamon-settings/bin/SettingsWidgets.py:390
+#: files/usr/share/cinnamon/cinnamon-settings/bin/SettingsWidgets.py:393
 msgid "Sound files"
 msgstr ""
 

files/usr/share/cinnamon/cinnamon-settings/bin/KeybindingWidgets.py

@@ -143,9 +143,17 @@ class CellRendererKeybinding(Gtk.CellRendererText):
                          GObject.ParamFlags.READWRITE)
     }
 
+    # l10n constants - get them translated here so they use Cinnamon's gettext context
     TOOLTIP_TEXT = "%s\n%s\n%s" % (_("Click to set a new accelerator key."),
                                    _("Press Escape or click again to cancel the operation."),
                                    _("Press Backspace to clear the existing keybinding."))
+    UNASSIGNED = _("unassigned")
+    PICK_AN_ACCELERATOR = _("Pick an accelerator")
+    MSG = _("\nThis key combination, \'<b>%s</b>\' should not be used because it would become impossible to type using this key. ")
+    MSG += _("Please try again using a modifier key such as Control, Alt or Super (Windows key).\n\n")
+    MSG += _("Continue only if you are certain this is what you want, otherwise press cancel.\n")
+    CANCEL = _("Cancel")
+    CONTINUE = _("Continue")
 
     def __init__(self, a_widget, accel_string=None):
         super(CellRendererKeybinding, self).__init__()
@@ -180,7 +188,7 @@ def do_set_property(self, prop, value):
             raise AttributeError(f'unknown property {prop.name}')
 
     def update_label(self):
-        text = _("unassigned") if self.default_value else self.text_string
+        text = CellRendererKeybinding.UNASSIGNED if self.default_value else self.text_string
         if self.accel_string:
             restore_atab = False
             restore_keyboard = False
@@ -224,7 +232,7 @@ def editing_started(self, renderer, editable, path):
                                Gdk.EventMask.KEY_PRESS_MASK | Gdk.EventMask.KEY_RELEASE_MASK,
                                None, Gdk.CURRENT_TIME)
 
-            editable.set_text(_("Pick an accelerator"))
+            editable.set_text(CellRendererKeybinding.PICK_AN_ACCELERATOR)
             self.accel_editable = editable
 
             self.release_event_id = self.accel_editable.connect( "key-release-event", self.on_key_release )
@@ -328,15 +336,12 @@ def on_key_release(self, widget, event):
                                            Gtk.MessageType.WARNING,
                                            Gtk.ButtonsType.NONE,
                                            None)
-                button = dialog.add_button(_("Cancel"), Gtk.ResponseType.CANCEL)
-                button = dialog.add_button(_("Continue"), Gtk.ResponseType.OK)
+                button = dialog.add_button(CellRendererKeybinding.CANCEL, Gtk.ResponseType.CANCEL)
+                button = dialog.add_button(CellRendererKeybinding.CONTINUE, Gtk.ResponseType.OK)
                 dialog.set_default_response(Gtk.ResponseType.CANCEL)
                 button.get_style_context().add_class(Gtk.STYLE_CLASS_DESTRUCTIVE_ACTION)
                 dialog.set_default_size(400, 200)
-                msg = _("\nThis key combination, \'<b>%s</b>\' should not be used because it would become impossible to type using this key. ")
-                msg += _("Please try again using a modifier key such as Control, Alt or Super (Windows key).\n\n")
-                msg += _("Continue only if you are certain this is what you want, otherwise press cancel.\n")
-                dialog.set_markup(msg % accel_label)
+                dialog.set_markup(CellRendererKeybinding.MSG % accel_label)
                 dialog.show_all()
                 response = dialog.run()
                 dialog.destroy()