Skip to content

Commit bdffa3d

Browse files
committed
authentication: Enable StEntry busy indicators in the screensaver
and polkit dialogs. The network auth one does not require it, as it does not stick around waiting for an outcome. If authentication fails there, it shows a new dialog. The keyring prompt doesn't seem to last long enough to need this sort of visual - it immediately returns.
1 parent 69a17a8 commit bdffa3d

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

js/ui/polkitAuthenticationAgent.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,7 @@ var AuthenticationDialog = GObject.registerClass({
389389
}
390390

391391
_onEntryActivate() {
392+
this._passwordEntry.start_busy();
392393
let response = this._passwordEntry.get_text();
393394
if (response.length === 0)
394395
return;
@@ -409,6 +410,8 @@ var AuthenticationDialog = GObject.registerClass({
409410
}
410411

411412
_onSessionCompleted(session, gainedAuthorization) {
413+
this._passwordEntry.end_busy();
414+
412415
if (this._completed || this._doneEmitted)
413416
return;
414417

@@ -466,6 +469,7 @@ var AuthenticationDialog = GObject.registerClass({
466469
}
467470

468471
_onSessionShowError(session, text) {
472+
this._passwordEntry.end_busy();
469473
this._passwordEntry.set_text('');
470474
this._errorMessageLabel.set_text(text);
471475
this._errorMessageLabel.show();
@@ -475,6 +479,7 @@ var AuthenticationDialog = GObject.registerClass({
475479
}
476480

477481
_onSessionShowInfo(session, text) {
482+
this._passwordEntry.end_busy();
478483
this._passwordEntry.set_text('');
479484
this._infoMessageLabel.set_text(text);
480485
this._infoMessageLabel.show();

js/ui/screensaver/unlockDialog.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,8 +333,10 @@ class UnlockDialog extends St.BoxLayout {
333333

334334
this._passwordEntry.reactive = false;
335335
this._passwordEntry.hint_text = _("Checking...");
336+
this._passwordEntry.start_busy();
336337
} else {
337338
this._passwordEntry.reactive = true;
339+
this._passwordEntry.end_busy();
338340
}
339341
}
340342

0 commit comments

Comments
 (0)