gwl: Avoid adding the window again after removal

anaximeno · anaximeno · commit b9023187e71f · 2026-02-17T04:10:23.000-01:00
This was triggering when using the show window in all workspaces option and was leading the app group representation to an irregular state where removed windows would still be counted and show irresponsible thumbnails.
diff --git a/files/usr/share/cinnamon/applets/grouped-window-list@cinnamon.org/workspace.js b/files/usr/share/cinnamon/applets/grouped-window-list@cinnamon.org/workspace.js
@@ -239,8 +239,10 @@ class Workspace {
         && this.state.monitorWatchList.indexOf(metaWindow.get_monitor()) > -1;
     }
 
-    windowWorkspaceChanged(display, metaWorkspace, metaWindow) {
-        this.windowAdded(metaWindow, metaWorkspace);
+    windowWorkspaceChanged(display, metaWindow, metaWorkspace) {
+        // If the window is removed the metaWorkspace will be null, in that
+        // case we wouldn't want to add the window again.
+        if (metaWorkspace !== null) this.windowAdded(metaWorkspace, metaWindow);
     }
 
     windowAdded(metaWorkspace, metaWindow, app, isFavoriteApp) {

Original file line number	Diff line number	Diff line change
`@@ -239,8 +239,10 @@ class Workspace {`
`239`	`239`	`&& this.state.monitorWatchList.indexOf(metaWindow.get_monitor()) > -1;`
`240`	`240`	`}`
`241`	`241`
`242`		`- windowWorkspaceChanged(display, metaWorkspace, metaWindow) {`
`243`		`- this.windowAdded(metaWindow, metaWorkspace);`
	`242`	`+ windowWorkspaceChanged(display, metaWindow, metaWorkspace) {`
	`243`	`+ // If the window is removed the metaWorkspace will be null, in that`
	`244`	`+ // case we wouldn't want to add the window again.`
	`245`	`+ if (metaWorkspace !== null) this.windowAdded(metaWorkspace, metaWindow);`
`244`	`246`	`}`
`245`	`247`
`246`	`248`	`windowAdded(metaWorkspace, metaWindow, app, isFavoriteApp) {`