global.screen: Remove remaining usage in js code, add deprecation

warnings.

The MetaScreen went away in 5.4 (wayland rebase), with its methods
mainly taken up by the MetaDisplay and MetaWorkspaceManager classes.

For backward compatibility with xlets, CinnamonScreen was added, and
has continued to be used heavily.

Add deprecation notes to documentation, and runtime warnings when
any screen methods are used.

Author: mtwebster

files/usr/share/cinnamon/applets/[email protected]/applet.js

@@ -195,20 +195,20 @@ class CinnamonBarApplet extends Applet.Applet {
         if (etime > (this._last_scroll_time + SCROLL_DELAY) ||
             edir !== this._last_scroll_direction) {
 
-            let index = global.screen.get_active_workspace_index();
+            let index = global.workspace_manager.get_active_workspace_index();
 
             let workspaceCycle = this.muffinSettings.get_boolean('workspace-cycle')
 
             if ((edir == Clutter.ScrollDirection.UP) == (this.scroll_behavior == 'normal')) {
                 index--;
-                if (index < 0) index = workspaceCycle ? global.screen.n_workspaces - 1 : 0;
+                if (index < 0) index = workspaceCycle ? global.workspace_manager.n_workspaces - 1 : 0;
             } else {
                 index++;
-                if (index == global.screen.n_workspaces) index = workspaceCycle ? 0 : index - 1;
+                if (index == global.workspace_manager.n_workspaces) index = workspaceCycle ? 0 : index - 1;
             }
 
-            if (global.screen.get_workspace_by_index(index) != null) {
-                global.screen.get_workspace_by_index(index).activate(global.get_current_time());
+            if (global.workspace_manager.get_workspace_by_index(index) != null) {
+                global.workspace_manager.get_workspace_by_index(index).activate(global.get_current_time());
             }
 
             this._last_scroll_direction = edir;

js/ui/appSwitcher/appSwitcher.js

@@ -68,7 +68,7 @@ function getWindowsForBinding(binding) {
     let showCurrentMonitorOnly = global.settings.get_boolean("alttab-switcher-show-current-monitor");
 
     if (showCurrentMonitorOnly) {
-        windows = windows.filter(w => w.get_monitor() === global.screen.get_current_monitor())
+        windows = windows.filter(w => w.get_monitor() === global.display.get_current_monitor())
     }
 
     switch (binding.get_name()) {

js/ui/applet.js

@@ -1142,7 +1142,7 @@ var PopupResizeHandler = class PopupResizeHandler {
 
     _collect_work_area_edges() {
         const monitor = Main.layoutManager.findMonitorForActor(this.actor);
-        const ws = global.screen.get_active_workspace();
+        const ws = global.workspace_manager.get_active_workspace();
         const area = ws.get_work_area_for_monitor(monitor.index);
 
         this._edges.top = area.y;

js/ui/layout.js

@@ -655,6 +655,32 @@ LayoutManager.prototype = {
      */
     isTrackingChrome: function(actor) {
         return this._chrome._findActor(actor) != -1;
+    },
+
+    /**
+     * getWindowAtPointer:
+     *
+     * Gets the MetaWindow under the mouse pointer. Only considers windows
+     * that are not completely obscured by other windows.
+     *
+     * Returns (Meta.Window): the MetaWindow under the pointer, or null if none found
+     */
+    getWindowAtPointer: function() {
+        let [pointerX, pointerY] = global.get_pointer();
+        let workspace = global.workspace_manager.get_active_workspace();
+        let windows = workspace.list_unobscured_windows();
+
+        for (let i = windows.length - 1; i >= 0; i--) {
+            let window = windows[i];
+            let rect = window.get_frame_rect();
+
+            if (pointerX >= rect.x && pointerX < rect.x + rect.width &&
+                pointerY >= rect.y && pointerY < rect.y + rect.height) {
+                return window;
+            }
+        }
+
+        return null;
     }
 };
 Signals.addSignalMethods(LayoutManager.prototype);