polkit: Show the reveal icon to reveal the password

The button should reflect its action, not the status of the entry.

This is better because:

- It's a button, it should reflect what it does.
- It aligns with the way this is done in other parts of Cinnamon,
slick-greeter, Mint tools and Firefox
- The default icon depicts an eye to reveal, that's an easier concept
to grasp than a hidden status with an icon representing the negation
of a simpler one.

Author: clefebvre

src/st/st-password-entry.c

@@ -160,7 +160,7 @@ st_password_entry_init (StPasswordEntry *entry)
 
   priv->peek_password_icon = g_object_new (ST_TYPE_ICON,
                                            "style-class", "peek-password",
-                                           "icon-name", "xsi-view-conceal-symbolic",
+                                           "icon-name", "xsi-view-reveal-symbolic",
                                            NULL);
   st_entry_set_secondary_icon (ST_ENTRY (entry), priv->peek_password_icon);
 
@@ -257,12 +257,12 @@ st_password_entry_set_password_visible (StPasswordEntry *entry,
   if (priv->password_visible)
     {
       clutter_text_set_password_char (CLUTTER_TEXT (clutter_text), 0);
-      st_icon_set_icon_name (ST_ICON (priv->peek_password_icon), "xsi-view-reveal-symbolic");
+      st_icon_set_icon_name (ST_ICON (priv->peek_password_icon), "xsi-view-conceal-symbolic");
     }
   else
     {
       clutter_text_set_password_char (CLUTTER_TEXT (clutter_text), BULLET);
-      st_icon_set_icon_name (ST_ICON (priv->peek_password_icon), "xsi-view-conceal-symbolic");
+      st_icon_set_icon_name (ST_ICON (priv->peek_password_icon), "xsi-view-reveal-symbolic");
     }
 
   g_object_notify (G_OBJECT (entry), "password-visible");