Some fixes, allow double-click to activate selected automount op.

Author: mtwebster

js/ui/autorunManager.js

@@ -327,6 +327,7 @@ class AutorunDialog extends ModalDialog.ModalDialog {
         this.contentLayout.add_child(description);
 
         this._appSection = new Dialog.ListSection({ selectable: true });
+        this._appSection.connect('row-activated', () => this._onOk());
         this.contentLayout.add_child(this._appSection);
 
         this._populateAppList();
@@ -396,7 +397,7 @@ class AutorunDialog extends ModalDialog.ModalDialog {
         if (!selected)
             return;
 
-        let remember = this._alwaysCheckBox.checked;
+        let remember = this._alwaysCheckBox?.checked ?? false;
 
         if (selected._autorunType === AUTORUN_ITEM_DO_NOTHING) {
             if (remember && this._contentType)

js/ui/cinnamonMountOperation.js

@@ -496,8 +496,10 @@ var CinnamonMountPasswordDialog = GObject.registerClass({
         this._passwordEntry.can_focus = !useKeyfiles;
         this._pimEntry.reactive = !useKeyfiles;
         this._pimEntry.can_focus = !useKeyfiles;
-        this._rememberChoice.reactive = !useKeyfiles;
-        this._rememberChoice.can_focus = !useKeyfiles;
+        if (this._rememberChoice) {
+            this._rememberChoice.reactive = !useKeyfiles;
+            this._rememberChoice.can_focus = !useKeyfiles;
+        }
         this._keyfilesLabel.visible = useKeyfiles;
         this.setButtons(useKeyfiles ? this._usesKeyfilesButtons : this._defaultButtons);
     }

js/ui/dialog.js

@@ -287,7 +287,8 @@ var ListSection = GObject.registerClass({
             false),
     },
     Signals: {
-        'selection-changed': { param_types: [GObject.TYPE_INT] },
+        'row-selected': { param_types: [GObject.TYPE_INT] },
+        'row-activated': { param_types: [GObject.TYPE_INT] },
     },
 }, class ListSection extends St.BoxLayout {
     _init(params) {
@@ -356,7 +357,7 @@ var ListSection = GObject.registerClass({
         });
 
         this._selectedIndex = index;
-        this.emit('selection-changed', index);
+        this.emit('row-selected', index);
     }
 
     _onItemClicked(item) {
@@ -372,6 +373,16 @@ var ListSection = GObject.registerClass({
         if (this.selectable) {
             item.reactive = true;
             item.track_hover = true;
+            item.connect('button-press-event', (actor, event) => {
+                if (event.get_click_count() === 2) {
+                    let children = this.list.get_children();
+                    let index = children.indexOf(item);
+                    if (index >= 0)
+                        this.emit('row-activated', index);
+                    return Clutter.EVENT_STOP;
+                }
+                return Clutter.EVENT_PROPAGATE;
+            });
             item.connect('button-release-event', () => {
                 this._onItemClicked(item);
                 return Clutter.EVENT_STOP;

js/ui/placesManager.js

@@ -135,8 +135,12 @@ PlaceDeviceInfo.prototype = {
             drive.can_stop()) {
             drive.stop(0, mountOp.mountOp, null, null);
         } else {
-            if ((drive && drive.can_eject()) || (volume && volume.can_eject()) || this._mount.can_eject())
+            if (drive && drive.can_eject())
                 drive.eject_with_operation(0, mountOp.mountOp, null, null);
+            else if (volume && volume.can_eject())
+                volume.eject_with_operation(0, mountOp.mountOp, null, null);
+            else if (this._mount.can_eject())
+                this._mount.eject_with_operation(0, mountOp.mountOp, null, null);
             else if (this._mount.can_unmount())
                 this._mount.unmount_with_operation(0, mountOp.mountOp, null, null);
         }

src/hotplug-sniffer/cinnamon-mime-sniffer.c

@@ -438,7 +438,7 @@ query_info_async_ready_cb (GObject *source,
                                G_IO_ERROR,
                                G_IO_ERROR_NOT_DIRECTORY,
                                "Not a directory");
-
+      g_object_unref (info);
       return;
     }